Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore new TS 2.0 unsupported options #308

Merged
merged 10 commits into from
Oct 18, 2016

Conversation

emilianosantucci
Copy link
Contributor

With this patch, typedoc will build docs also in TS 2.x projects without errors.

Warning: actually this is only a workaround to allow typedoc to get out docs but it need to improve in internal logic to handle new TypeScript features.

Ignore new TypeScript 2.0 options until official typedoc can't manage it
# Conflicts:
#	src/lib/utils/options/sources/typescript.ts
@christopherthielen
Copy link
Contributor

christopherthielen commented Oct 16, 2016

Note that your PR automatically updates as you push commits to the branch. Did you mean to add all the generated files? You'll probably have to redo the original PR

@emilianosantucci
Copy link
Contributor Author

@christopherthielen, thanks for suggestion. Looking into linked typedoc plugins, I've also notice the usage of typedoc source code but it was not exported on NPM package so I add it.
If the last commit can be confusing about PR target, I can redo and post a new PR after that.

@blakeembrey
Copy link
Member

Please don't check in built files, they are ignored for a reason. I'll review once you remove them.

@emilianosantucci
Copy link
Contributor Author

@blakeembrey I have fix it.

@@ -56,6 +56,7 @@
"bin",
"lib",
"tasks",
"src",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blakeembrey blakeembrey merged commit 178f68c into TypeStrong:master Oct 18, 2016
@unsafecode
Copy link

Do we have an estimation for the release of this fix? Thanks

@jonaskello
Copy link

+1 Could we please have a release with this merged so we can use Typedoc in TS 2.0?

@christopherthielen
Copy link
Contributor

@jonaskello
Copy link

@christopherthielen 👍 Thanks, I didn't notice that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants