-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore new TS 2.0 unsupported options #308
Conversation
Ignore new TypeScript 2.0 options until official typedoc can't manage it
# Conflicts: # src/lib/utils/options/sources/typescript.ts
Note that your PR automatically updates as you push commits to the branch. Did you mean to add all the generated files? You'll probably have to redo the original PR |
@christopherthielen, thanks for suggestion. Looking into linked typedoc plugins, I've also notice the usage of typedoc source code but it was not exported on NPM package so I add it. |
Please don't check in built files, they are ignored for a reason. I'll review once you remove them. |
@blakeembrey I have fix it. |
@@ -56,6 +56,7 @@ | |||
"bin", | |||
"lib", | |||
"tasks", | |||
"src", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Do we have an estimation for the release of this fix? Thanks |
+1 Could we please have a release with this merged so we can use Typedoc in TS 2.0? |
https://github.com/TypeStrong/typedoc/releases/tag/v0.5.1 This was released last week. |
@christopherthielen 👍 Thanks, I didn't notice that :-) |
With this patch,
typedoc
will build docs also in TS 2.x projects without errors.Warning: actually this is only a workaround to allow
typedoc
to get out docs but it need to improve in internal logic to handle new TypeScript features.