Support baseUrl and paths compiler options
#342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like all the recently opened PRs are failing with the same compile error in CI. Is there something I need to fix here before this is ready to merge? Everything seems to compile fine for me locally (running |
fencim
approved these changes
Dec 8, 2016
|
@blakeembrey This one can be merged safely looks like, though looks like maybe it needs a release bump too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #340.
The
pathsoption, which is expected to be a JSON object mapping strings to arrays of strings, comes with an internal TS option declaration with propertymap: 'object', so we special-case the option-setting logic when we find that property on the declaration. This sticks the wholepathsobject unchanged intooptions.compilerOptions, which is forwarded on tots.createProgramin the converter.