Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HelperStack): deactivate theme resources correctly #865

Merged
merged 1 commit into from
Oct 3, 2018
Merged

fix(HelperStack): deactivate theme resources correctly #865

merged 1 commit into from
Oct 3, 2018

Conversation

Aleksandyr
Copy link
Contributor

Closes #864

@zdrawku
Copy link
Contributor

zdrawku commented Oct 2, 2018

Locally are failing only two tests, that has nothing to do with the code change itself.

With or witohut the code change, these two tests are failing:

image

image

@aciccarello
Copy link
Collaborator

Thanks for the contribution. I saw the same tests failing on another PR so its helpful to know that it is not just that one.

@zdrawku
Copy link
Contributor

zdrawku commented Oct 3, 2018

@aciccarello what do you think of the code change? It looks just a little change, although I am sure that we must be careful with the verification.

I wanted to ask you, what could we expect, is it possible to review and verify the PR by the end of this week, or before 10th of October? I am asking because this is a showstopper for a feature that we are currently developing.

In addition, we've notices that our change is not used anywhere in the typdoc library, it looks like it is exposed for external use only.

Looking forward to your thoughts!

@aciccarello
Copy link
Collaborator

That seems reasonable since it does not seem to be called. I'll merge this and try to get a release out this week including #863 if possible.

@aciccarello aciccarello merged commit f7d5683 into TypeStrong:master Oct 3, 2018
@zdrawku
Copy link
Contributor

zdrawku commented Oct 3, 2018

Thank you @aciccarello!

@zdrawku
Copy link
Contributor

zdrawku commented Oct 8, 2018

Hi @aciccarello, I am following up on the release that will include this PR change and #863, do you have any updates on this?

@zdrawku
Copy link
Contributor

zdrawku commented Oct 8, 2018

@aciccarello ! :) version 0.13.0-0 is what we have been waitng for.
Thank you, everything is wokring like a charm now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants