Skip to content

Adds helper that removes double-quotes from string #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Fleker
Copy link
Contributor

@Fleker Fleker commented Oct 23, 2018

In my Typedoc generation, the modules are shown in quotes
This introduces a helper that will remove quotes in my theme

@aciccarello
Copy link
Collaborator

Thanks for the PR, I hope to review soon. Note, there is a related discussion in #68

@aciccarello
Copy link
Collaborator

@Fleker thanks for the contribution. Is there any reason this needs to be in the typedoc helpers if it isn't used in any typedoc core?

Also, if you complete your theme, you are welcome to add it to the readme.

@Fleker
Copy link
Contributor Author

Fleker commented Oct 25, 2018

I had scanned through the Typedoc code, although I couldn't find a way to add a Handlebar helper directly through my theme as part of a plugin. I could see how plugins are added, but I wasn't sure that I'd be able to use the same Handlebar context between my plugin and Typedoc.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 6, 2018

#864 details one way to add custom handlebar helpers, without requiring additions to the TypeDoc core. This needs to be documented somewhere.

Ironically, documentation is one of the largest problems with TypeDoc right now. There's a lot of documentation that needs to be improved (or created).

@aciccarello
Copy link
Collaborator

See #154 (comment) for how to add custom helpers to your theme. It essentially involves adding a helpers directory. Hopefully we can add some better documentation for this moving forward.

@aciccarello aciccarello closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants