Allow install beta #211
Merged
Allow install beta #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chemaclass
force-pushed
the
feat/210-allow-install-main
branch
from
171aa06
to
161cff5
Compare
Chemaclass
force-pushed
the
feat/210-allow-install-main
branch
from
870bd4b
to
1040539
Compare
Chemaclass
force-pushed
the
feat/210-allow-install-main
branch
from
aaaa4b4
to
53ba5fa
Compare
|
Can you help me with the failing test, @Tito-Kati or @khru ? I cannot reproduce it locally (with my MacOS) 🤔 |
| @@ -7,6 +7,6 @@ cat bashunit >> bin/temp.sh | |||
| grep -v '^source' bin/temp.sh > bin/bashunit | |||
| rm bin/temp.sh | |||
|
|
|||
| chmod +x bin/bashunit | |||
| chmod u+x bin/bashunit | |||
antonio-gg-dev
requested changes
Nov 7, 2023
antonio-gg-dev
approved these changes
Nov 8, 2023
|
I've fixed the error that the workflows were giving on Linux. By removing the git mock, I could have fixed the mock, but being an acceptance test, it seemed more correct to remove it. Additionally, I've taken the liberty of applying the corrections I requested myself and making a few more minor changes. |
khru
reviewed
Nov 8, 2023
| echo "> Downloading the latest version: '$TAG'" | ||
| fi | ||
|
|
||
| curl -L -O -J "https://github.com/TypedDevs/bashunit/releases/download/$TAG/bashunit" 2>/dev/null |
There was a problem hiding this comment.
Would it make senses to add header on the curl to track the version requested as well as the OS that is using?
There was a problem hiding this comment.
khru
requested changes
Nov 8, 2023
tests/acceptance/install_test.sh
Outdated
| "$(printf "> Downloading non-stable version: 'beta'\n> bashunit has been installed in the 'deps' folder")"\ | ||
| "$output" | ||
| assert_file_exists "$install_dir" | ||
| assert_equals "$(printf "\e[1m\e[32mbashunit\e[0m - (non-stable) beta")" "$("$install_dir" --version)" |
There was a problem hiding this comment.
We are missing to test that the dir has been deleted
# Conflicts: # tests/acceptance/install_test.sh
khru
approved these changes
Nov 9, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Closes: #210
Currently, the installer tool allows you to install a concrete version, once it was release. However, there is no easy way to benefit of the features/bug-fixes already merged into main unless you download the project and run the build.sh yourself.
🔖 Changes
✅ To-do list
CHANGELOG.mdto reflect the new feature or fix