Fix: assert_line_count #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chemaclass
requested review from
cmayo,
khru,
JesusValera,
antonio-gg-dev and
fabriziofs
staabm
reviewed
Jun 17, 2024
Comment on lines
+328
to
+329
| actual=$(echo "$input_str" | wc -l | tr -d '[:blank:]') | ||
| additional_new_lines=$(grep -o '\\n' <<< "$input_str" | wc -l | tr -d '[:blank:]') |
There was a problem hiding this comment.
I don't get why/how bash represents the newline in 2 different characters.. but the tests seem to show it works.
I don't know why 😅
There was a problem hiding this comment.
Same here... I just got to this solution driven by the tests, I don't understand why this works... so it's bash... 🤣
And here, yet, another proof that TDD works 😝
fabriziofs
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Related to: phpstan/phpstan-src#3160 (comment)
🔖 Changes
\nof a string onassert_line_count