Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading extra file with BASHUNIT_LOAD_FILE #330

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Conversation

Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Sep 16, 2024

📚 Description

Currently, we can load any file (using native source) with -e|--env but this sounds grammatically wrong when loading a bash script that contains global functions (apart of optional global variables (like another .env, for example).

🔖 Changes

  • Rename BASHUNIT_TESTS_ENV to BASHUNIT_LOAD_FILE
  • Add --load option
    • Load a custom file, overriding the existing .env variables or loading a file with global functions.

✅ To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix
  • I updated the documentation to reflect the changes

@Chemaclass Chemaclass added the enhancement New feature or request label Sep 16, 2024
@Chemaclass Chemaclass self-assigned this Sep 16, 2024
@Chemaclass Chemaclass marked this pull request as draft September 16, 2024 07:51
@Chemaclass Chemaclass marked this pull request as ready for review September 17, 2024 14:15
@Chemaclass Chemaclass changed the title Load file Improve loading extra file with BASHUNIT_LOAD_FILE Sep 17, 2024
@Chemaclass Chemaclass merged commit 68ed162 into main Sep 17, 2024
7 checks passed
@Chemaclass Chemaclass deleted the feat/load-file branch September 17, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants