Add test duration #333
Merged
Add test duration #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chemaclass
commented
Sep 21, 2024
| printf "%s | Total tests: %s\n" "$BASHUNIT_VERSION" "$total_tests" | ||
| printf "%s | Tests: ~%s\n" "$BASHUNIT_VERSION" "$total_tests" |
There was a problem hiding this comment.
Reason: counting total tests is easy, but not the data providers. Therefore, I would like an overview of the number of tests. Still, I don't mind (at least for now) the exact consideration of data_provider level, especially considering that this might be performance-wise costly... so I would rather postpone this (if even needed).
Therefore, I added the ~ to clarify that this is an honest estimation.
JesusValeraDev
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Right now, you can see total exec time only at the end but not on the individual test level.
🔖 Changes
Display test runtime if
BASHUNIT_SHOW_EXECUTION_TIMEis enabled✅ To-do list
CHANGELOG.mdto reflect the new feature or fix🖼️ Demo
BEFORE
AFTER