-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running in parallel #358
Running in parallel #358
Conversation
simplify parallel.sh
Conflicts: .github/workflows/tests.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job as always !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just say that for me parallel testing should always be the default way to run, as it is not just for performance, but also to know that your tests do not depend on each other,
I would rather suggest that it be always active by default in subsequent versions and that it can be disabled.
That's my opinion, I think that the value that active brings is always greater, and that only in case you need to disable it because your code needs it, you do it.
This opens up other issues such as being able to prevent a test file from being launched in parallel, this is common in other testing frameworks.
The tests are not good in alpine |
I would rather not keep the parallel testing as default behavior but as it was until now. Aiming for simplicity, I am in favor of: PS: Yes, I saw something is not good in alpine. I will check it... ποΈ |
9bdf244
to
170f064
Compare
7c70e3f
to
8bb1d1a
Compare
8bb1d1a
to
155e694
Compare
π Description
Closes: #354
π Changes
-p|--parallel
--no-parallel
β To-do list
CHANGELOG.md
to reflect the new feature or fixπΌοΈ Screenshots
Running the entire test suite sync (~43s)
Running the entire test suite in parallel (~15s) - 65.12% improment! π
Running parallel tests (detailed)
Documentation