Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BubbleTooltip): Fix positioning for multiple line selection #7

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

mumpo
Copy link

@mumpo mumpo commented Nov 25, 2020

What does this PR do?

This PR extends the tooltip position correction for multiple line selections added here eb4a1cd , adding the same calculation for any optimize event related recalculations.

How to reproduce?

  1. Configure the editor with bubble theme
  2. Type a 3 line text
  3. Select everything
  4. The toolbar tooltip appears in the correct position (thanks to previous fix)
  5. Click the bold format or any format
  6. The position of the tooltip is recalculated incorrectly

Related issue

Improves the fix for this issue: slab#706

@mumpo mumpo merged commit adff8a5 into develop Nov 25, 2020
@mumpo mumpo deleted the fix/multiple-selection branch November 25, 2020 09:39
@travis-tf
Copy link

🎉 This PR is included in version 2.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@travis-tf
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants