Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream #29

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Update upstream #29

merged 1 commit into from
Mar 21, 2018

Conversation

GulajavaMinistudio
Copy link

…iguration with DI (angular#1454)

  • First.

  • SSR work

  • StorageBucket is a string...

  • Add AngularFireModule back in

  • Fix up storage and the tests

  • Adding StorageBucket and DatabaseURL DI tests

  • Adding specs for DI in auth + firestore

  • More complete tests + fixed the storage test config

  • Adding app.module back in and writing tests for app injection

  • Export RealtimeDatabaseURL from database-deprecated

  • Export FirebaseApp

  • Working, needs wrapper

  • More

  • State changes and auditlog

  • Wrap auth

  • Reverted database-depricated a bit

  • More cleanup

  • Cleanup unused imports

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

…iguration with DI (#1454)

* First.

* SSR work

* StorageBucket is a string...

* Add AngularFireModule back in

* Fix up storage and the tests

* Adding StorageBucket and DatabaseURL DI tests

* Adding specs for DI in auth + firestore

* More complete tests + fixed the storage test config

* Adding app.module back in and writing tests for app injection

* Export RealtimeDatabaseURL from database-deprecated

* Export FirebaseApp

* Working, needs wrapper

* More

* State changes and auditlog

* Wrap auth

* Reverted database-depricated a bit

* More cleanup

* Cleanup unused imports
@GulajavaMinistudio GulajavaMinistudio merged commit f4dc9aa into TypescriptID:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants