Update upstream #29
Merged
Update upstream #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration with DI (#1454) * First. * SSR work * StorageBucket is a string... * Add AngularFireModule back in * Fix up storage and the tests * Adding StorageBucket and DatabaseURL DI tests * Adding specs for DI in auth + firestore * More complete tests + fixed the storage test config * Adding app.module back in and writing tests for app injection * Export RealtimeDatabaseURL from database-deprecated * Export FirebaseApp * Working, needs wrapper * More * State changes and auditlog * Wrap auth * Reverted database-depricated a bit * More cleanup * Cleanup unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iguration with DI (angular#1454)
First.
SSR work
StorageBucket is a string...
Add AngularFireModule back in
Fix up storage and the tests
Adding StorageBucket and DatabaseURL DI tests
Adding specs for DI in auth + firestore
More complete tests + fixed the storage test config
Adding app.module back in and writing tests for app injection
Export RealtimeDatabaseURL from database-deprecated
Export FirebaseApp
Working, needs wrapper
More
State changes and auditlog
Wrap auth
Reverted database-depricated a bit
More cleanup
Cleanup unused imports
Checklist
yarn install,yarn testrun successfully? (yes/no; required)Description
Code sample