Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Feat/word export #36

Merged
merged 7 commits into from
Nov 7, 2022
Merged

Feat/word export #36

merged 7 commits into from
Nov 7, 2022

Conversation

NealGeilen
Copy link
Collaborator

Adding the functionality to the project for exporting to "Word" files aka ".docx"

This is mostly done as a test to see what it takes to create word documents within .NET.
I wanted to test this so that there is a base when we want to start the development of a "competence document generator"

@NealGeilen NealGeilen self-assigned this Oct 27, 2022
@NealGeilen NealGeilen changed the base branch from master to develop October 27, 2022 20:11
@NealGeilen NealGeilen linked an issue Oct 27, 2022 that may be closed by this pull request
@Typiqally
Copy link
Owner

Typiqally commented Oct 27, 2022

Nice work, I'll take a look when you are ready for review :D. Should really refactor the code again some day, It's still a bit messy for my liking.

EDIT: To clarify, I'm talking about the general codebase, not your commits.

@NealGeilen
Copy link
Collaborator Author

NealGeilen commented Oct 27, 2022

I was thinking, is it still needed to have a pdf export format? #27

I just don't think that there is a need for it. Especially looking at the fact that you can't edit a pdf document. With this a user can only copy the contents of the document. And you can already do that with the other export formats.

@Typiqally
Copy link
Owner

Typiqally commented Oct 28, 2022

I was thinking, is it still needed to have a pdf export format? #27

I just don't think that there is a need for it. Especially looking at the fact that you can't edit a pdf document. With this a user can only copy the contents of the document. And you can already do that with the other export formats.

That's fair, you can remove it from the issue if you want. Do you think it is also possible to include other "Word" formats such as otd, for Linux users?

@NealGeilen NealGeilen marked this pull request as ready for review November 4, 2022 09:09
@NealGeilen NealGeilen requested a review from Typiqally November 4, 2022 09:09
Copy link
Owner

@Typiqally Typiqally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, left some small review comments. I was also wondering if you spent time on Linux compatible formats such as OTD?

Epsilon/Export/Exporters/WordModuleExporter.cs Outdated Show resolved Hide resolved
Epsilon/Export/Exporters/WordModuleExporter.cs Outdated Show resolved Hide resolved
Epsilon/Export/Exporters/WordModuleExporter.cs Outdated Show resolved Hide resolved
@NealGeilen
Copy link
Collaborator Author

I was also wondering if you spent time on Linux compatible formats such as OTD?

At this moment I cant find a .NET lib that supports this format.

@NealGeilen NealGeilen requested a review from Typiqally November 5, 2022 09:12
@Typiqally
Copy link
Owner

I was also wondering if you spent time on Linux compatible formats such as OTD?

At this moment I cant find a .NET lib that supports this format.

That's fine, I believe many Word editing tools support the MS Word format on Linux anyway.

Copy link
Owner

@Typiqally Typiqally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really liking the helper functions, nicely done, still have some minor changes requests

Epsilon/Export/Exporters/ExcelModuleExporter.cs Outdated Show resolved Hide resolved
Epsilon/Export/Exporters/WordModuleExporter.cs Outdated Show resolved Hide resolved
Epsilon/Export/Exporters/WordModuleExporter.cs Outdated Show resolved Hide resolved
@NealGeilen NealGeilen requested a review from Typiqally November 7, 2022 10:37
@Typiqally Typiqally merged commit 3657d66 into develop Nov 7, 2022
@Typiqally Typiqally deleted the feat/word-export branch November 8, 2022 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word export format
2 participants