-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Nice work, I'll take a look when you are ready for review :D. Should really refactor the code again some day, It's still a bit messy for my liking. EDIT: To clarify, I'm talking about the general codebase, not your commits. |
I was thinking, is it still needed to have a pdf export format? #27 I just don't think that there is a need for it. Especially looking at the fact that you can't edit a pdf document. With this a user can only copy the contents of the document. And you can already do that with the other export formats. |
That's fair, you can remove it from the issue if you want. Do you think it is also possible to include other "Word" formats such as otd, for Linux users? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, left some small review comments. I was also wondering if you spent time on Linux compatible formats such as OTD?
At this moment I cant find a .NET lib that supports this format. |
That's fine, I believe many Word editing tools support the MS Word format on Linux anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really liking the helper functions, nicely done, still have some minor changes requests
Adding the functionality to the project for exporting to "Word" files aka ".docx"
This is mostly done as a test to see what it takes to create word documents within .NET.
I wanted to test this so that there is a base when we want to start the development of a "competence document generator"