Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test cases for shuffle and sorts that promise unique output #56

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Added test cases for shuffle and sorts that promise unique output #56

merged 1 commit into from
Oct 29, 2019

Conversation

boredcity
Copy link

I mocked Math.random to test shuffle behaviour and added duplicate lines in test cases to test sorts that promise unique output.

hope it's useful

@boredcity
Copy link
Author

I also have a PR adding "remove duplicate lines" ready but that one required quite a bit of refactoring and is depending on this one... 😢

@Tyriar
Copy link
Owner

Tyriar commented Oct 29, 2019

Thanks!

@Tyriar Tyriar merged commit 7fe0271 into Tyriar:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boredcity @Tyriar