Remove Channel.ParentNameWithFallback

DiscordChatExporter.Cli/Commands/Base/ExportCommandBase.cs

@@ -200,7 +200,7 @@ await Parallel.ForEachAsync(
                         try
                         {
                             await progressContext.StartTaskAsync(
-                                $"{channel.ParentNameWithFallback} / {channel.Name}",
+                                channel.GetHierarchicalName(),
                                 async progress =>
                                 {
                                     var guild = await Discord.GetGuildAsync(
@@ -263,10 +263,7 @@ await console.Error.WriteLineAsync(
 
             foreach (var (channel, error) in errorsByChannel)
             {
-                await console.Error.WriteAsync(
-                    $"{channel.ParentNameWithFallback} / {channel.Name}: "
-                );
-
+                await console.Error.WriteAsync($"{channel.GetHierarchicalName()}: ");
                 using (console.WithForegroundColor(ConsoleColor.Red))
                     await console.Error.WriteLineAsync(error);
             }
@@ -294,7 +291,7 @@ protected async ValueTask ExportAsync(IConsole console, IReadOnlyList<Snowflake>
             var channel = await Discord.GetChannelAsync(channelId, cancellationToken);
 
             // Unwrap categories
-            if (channel.Kind == ChannelKind.GuildCategory)
+            if (channel.IsCategory)
             {
                 var guildChannels =
                     channelsByGuild.GetValueOrDefault(channel.GuildId)

DiscordChatExporter.Cli/Commands/ExportAllCommand.cs

@@ -60,10 +60,10 @@ public override async ValueTask ExecuteAsync(IConsole console)
                     var channel in Discord.GetGuildChannelsAsync(guild.Id, cancellationToken)
                 )
                 {
-                    if (channel.Kind == ChannelKind.GuildCategory)
+                    if (channel.IsCategory)
                         continue;
 
-                    if (!IncludeVoiceChannels && channel.Kind.IsVoice())
+                    if (!IncludeVoiceChannels && channel.IsVoice)
                         continue;
 
                     channels.Add(channel);
@@ -129,15 +129,15 @@ await console.Error.WriteLineAsync(
 
         // Filter out unwanted channels
         if (!IncludeDirectChannels)
-            channels.RemoveAll(c => c.Kind.IsDirect());
+            channels.RemoveAll(c => c.IsDirect);
         if (!IncludeGuildChannels)
-            channels.RemoveAll(c => c.Kind.IsGuild());
+            channels.RemoveAll(c => c.IsGuild);
         if (!IncludeVoiceChannels)
-            channels.RemoveAll(c => c.Kind.IsVoice());
+            channels.RemoveAll(c => c.IsVoice);
         if (ThreadInclusionMode == ThreadInclusionMode.None)
-            channels.RemoveAll(c => c.Kind.IsThread());
+            channels.RemoveAll(c => c.IsThread);
         if (ThreadInclusionMode != ThreadInclusionMode.All)
-            channels.RemoveAll(c => c.Kind.IsThread() && c.IsArchived);
+            channels.RemoveAll(c => c is { IsThread: true, IsArchived: true });
 
         await ExportAsync(console, channels);
     }

DiscordChatExporter.Cli/Commands/ExportGuildCommand.cs

@@ -38,10 +38,10 @@ public override async ValueTask ExecuteAsync(IConsole console)
         // Regular channels
         await foreach (var channel in Discord.GetGuildChannelsAsync(GuildId, cancellationToken))
         {
-            if (channel.Kind == ChannelKind.GuildCategory)
+            if (channel.IsCategory)
                 continue;
 
-            if (!IncludeVoiceChannels && channel.Kind.IsVoice())
+            if (!IncludeVoiceChannels && channel.IsVoice)
                 continue;
 
             channels.Add(channel);

DiscordChatExporter.Cli/Commands/GetChannelsCommand.cs

@@ -35,8 +35,8 @@ public override async ValueTask ExecuteAsync(IConsole console)
         var cancellationToken = console.RegisterCancellationHandler();
 
         var channels = (await Discord.GetGuildChannelsAsync(GuildId, cancellationToken))
-            .Where(c => c.Kind != ChannelKind.GuildCategory)
-            .Where(c => IncludeVoiceChannels || !c.Kind.IsVoice())
+            .Where(c => !c.IsCategory)
+            .Where(c => IncludeVoiceChannels || !c.IsVoice)
             .OrderBy(c => c.Parent?.Position)
             .ThenBy(c => c.Name)
             .ToArray();
@@ -72,11 +72,9 @@ await console.Output.WriteAsync(
             using (console.WithForegroundColor(ConsoleColor.DarkGray))
                 await console.Output.WriteAsync(" | ");
 
-            // Channel category / name
+            // Channel name
             using (console.WithForegroundColor(ConsoleColor.White))
-                await console.Output.WriteLineAsync(
-                    $"{channel.ParentNameWithFallback} / {channel.Name}"
-                );
+                await console.Output.WriteLineAsync(channel.GetHierarchicalName());
 
             var channelThreads = threads.Where(t => t.Parent?.Id == channel.Id).ToArray();
             var channelThreadIdMaxLength = channelThreads

DiscordChatExporter.Cli/Commands/GetDirectChannelsCommand.cs

@@ -21,7 +21,6 @@ public override async ValueTask ExecuteAsync(IConsole console)
         var channels = (
             await Discord.GetGuildChannelsAsync(Guild.DirectMessages.Id, cancellationToken)
         )
-            .Where(c => c.Kind != ChannelKind.GuildCategory)
             .OrderByDescending(c => c.LastMessageId)
             .ThenBy(c => c.Name)
             .ToArray();
@@ -42,11 +41,9 @@ await console.Output.WriteAsync(
             using (console.WithForegroundColor(ConsoleColor.DarkGray))
                 await console.Output.WriteAsync(" | ");
 
-            // Channel category / name
+            // Channel name
             using (console.WithForegroundColor(ConsoleColor.White))
-                await console.Output.WriteLineAsync(
-                    $"{channel.ParentNameWithFallback} / {channel.Name}"
-                );
+                await console.Output.WriteLineAsync(channel.GetHierarchicalName());
         }
     }
 }

DiscordChatExporter.Core/Discord/Data/Channel.cs

@@ -1,4 +1,5 @@
-using System.Linq;
+using System.Collections.Generic;
+using System.Linq;
 using System.Text.Json;
 using DiscordChatExporter.Core.Discord.Data.Common;
 using DiscordChatExporter.Core.Utils.Extensions;
@@ -20,32 +21,36 @@ public partial record Channel(
     Snowflake? LastMessageId
 ) : IHasId
 {
-    // Used for visual backwards-compatibility with old exports, where
-    // channels without a parent (i.e. mostly DM channels) or channels
-    // with an inaccessible parent (i.e. inside private categories) had
-    // a fallback category created for them.
-    public string ParentNameWithFallback =>
-        Parent?.Name
-        ?? Kind switch
-        {
-            ChannelKind.GuildCategory => "Category",
-            ChannelKind.GuildTextChat => "Text",
-            ChannelKind.DirectTextChat => "Private",
-            ChannelKind.DirectGroupTextChat => "Group",
-            ChannelKind.GuildPrivateThread => "Private Thread",
-            ChannelKind.GuildPublicThread => "Public Thread",
-            ChannelKind.GuildNews => "News",
-            ChannelKind.GuildNewsThread => "News Thread",
-            _ => "Default"
-        };
+    public bool IsDirect => Kind is ChannelKind.DirectTextChat or ChannelKind.DirectGroupTextChat;
+
+    public bool IsGuild => !IsDirect;
+
+    public bool IsCategory => Kind == ChannelKind.GuildCategory;
+
+    public bool IsVoice => Kind is ChannelKind.GuildVoiceChat or ChannelKind.GuildStageVoice;
+
+    public bool IsThread =>
+        Kind
+            is ChannelKind.GuildNewsThread
+                or ChannelKind.GuildPublicThread
+                or ChannelKind.GuildPrivateThread;
 
     public bool IsEmpty => LastMessageId is null;
 
-    // Only needed for WPF data binding. Don't use anywhere else.
-    public bool IsVoice => Kind.IsVoice();
+    public IEnumerable<Channel> GetParents()
+    {
+        var current = Parent;
+        while (current is not null)
+        {
+            yield return current;
+            current = current.Parent;
+        }
+    }
+
+    public Channel? TryGetRootParent() => GetParents().LastOrDefault();
 
-    // Only needed for WPF data binding. Don't use anywhere else.
-    public bool IsThread => Kind.IsThread();
+    public string GetHierarchicalName() =>
+        string.Join(" / ", GetParents().Reverse().Select(c => c.Name).Append(Name));
 
     public bool MayHaveMessagesAfter(Snowflake messageId) => !IsEmpty && messageId < LastMessageId;
 

DiscordChatExporter.Core/Discord/Data/ChannelKind.cs

@@ -16,20 +16,3 @@ public enum ChannelKind
     GuildDirectory = 14,
     GuildForum = 15
 }
-
-public static class ChannelKindExtensions
-{
-    public static bool IsDirect(this ChannelKind kind) =>
-        kind is ChannelKind.DirectTextChat or ChannelKind.DirectGroupTextChat;
-
-    public static bool IsGuild(this ChannelKind kind) => !kind.IsDirect();
-
-    public static bool IsVoice(this ChannelKind kind) =>
-        kind is ChannelKind.GuildVoiceChat or ChannelKind.GuildStageVoice;
-
-    public static bool IsThread(this ChannelKind kind) =>
-        kind
-            is ChannelKind.GuildNewsThread
-                or ChannelKind.GuildPublicThread
-                or ChannelKind.GuildPrivateThread;
-}

DiscordChatExporter.Core/Discord/Data/Guild.cs

@@ -6,7 +6,12 @@
 namespace DiscordChatExporter.Core.Discord.Data;
 
 // https://discord.com/developers/docs/resources/guild#guild-object
-public record Guild(Snowflake Id, string Name, string IconUrl) : IHasId
+public partial record Guild(Snowflake Id, string Name, string IconUrl) : IHasId
+{
+    public bool IsDirect => Id == DirectMessages.Id;
+}
+
+public partial record Guild
 {
     // Direct messages are encapsulated within a special pseudo-guild for consistency
     public static Guild DirectMessages { get; } =

DiscordChatExporter.Core/Discord/Data/Message.cs

@@ -30,7 +30,13 @@ public partial record Message(
     Interaction? Interaction
 ) : IHasId
 {
-    public bool IsReplyLike => Kind == MessageKind.Reply || Interaction is not null;
+    public bool IsSystemNotification =>
+        Kind is >= MessageKind.RecipientAdd and <= MessageKind.ThreadCreated;
+
+    public bool IsReply => Kind == MessageKind.Reply;
+
+    // App interactions are rendered as replies in the Discord client, but they are not actually replies
+    public bool IsReplyLike => IsReply || Interaction is not null;
 
     public IEnumerable<User> GetReferencedUsers()
     {

DiscordChatExporter.Core/Discord/Data/MessageKind.cs

@@ -14,8 +14,3 @@ public enum MessageKind
     ThreadCreated = 18,
     Reply = 19
 }
-
-public static class MessageKindExtensions
-{
-    public static bool IsSystemNotification(this MessageKind kind) => (int)kind is >= 1 and <= 18;
-}

DiscordChatExporter.Core/Discord/DiscordClient.cs

@@ -286,11 +286,12 @@ public async IAsyncEnumerable<Channel> GetGuildThreadsAsync(
             yield break;
 
         var tokenKind = _resolvedTokenKind ??= await GetTokenKindAsync(cancellationToken);
+
         var channels = (await GetGuildChannelsAsync(guildId, cancellationToken))
             // Categories cannot have threads
-            .Where(c => c.Kind != ChannelKind.GuildCategory)
+            .Where(c => !c.IsCategory)
             // Voice channels cannot have threads
-            .Where(c => !c.Kind.IsVoice())
+            .Where(c => !c.IsVoice)
             // Empty channels cannot have threads
             .Where(c => !c.IsEmpty)
             // If the 'before' boundary is specified, skip channels that don't have messages

DiscordChatExporter.Core/Exporting/CsvMessageWriter.cs

@@ -92,7 +92,7 @@ public override async ValueTask WriteMessageAsync(
         await _writer.WriteAsync(',');
 
         // Message content
-        if (message.Kind.IsSystemNotification())
+        if (message.IsSystemNotification)
         {
             await _writer.WriteAsync(CsvEncode(message.GetFallbackContent()));
         }

DiscordChatExporter.Core/Exporting/ExportRequest.cs

@@ -99,10 +99,21 @@ public static string GetDefaultOutputFileName(
     {
         var buffer = new StringBuilder();
 
-        // Guild and channel names
-        buffer.Append(
-            $"{guild.Name} - {channel.ParentNameWithFallback} - {channel.Name} [{channel.Id}]"
-        );
+        // Guild name
+        buffer.Append(guild.Name);
+
+        // Parent name
+        if (channel.Parent is not null)
+            buffer.Append(" - ").Append(channel.Parent.Name);
+
+        // Channel name and ID
+        buffer
+            .Append(" - ")
+            .Append(channel.Name)
+            .Append(' ')
+            .Append('[')
+            .Append(channel.Id)
+            .Append(']');
 
         // Date range
         if (after is not null || before is not null)
@@ -142,9 +153,8 @@ private static string FormatPath(
         Channel channel,
         Snowflake? after,
         Snowflake? before
-    )
-    {
-        return Regex.Replace(
+    ) =>
+        Regex.Replace(
             path,
             "%.",
             m =>
@@ -153,14 +163,18 @@ private static string FormatPath(
                     {
                         "%g" => guild.Id.ToString(),
                         "%G" => guild.Name,
+
                         "%t" => channel.Parent?.Id.ToString() ?? "",
                         "%T" => channel.Parent?.Name ?? "",
+
                         "%c" => channel.Id.ToString(),
                         "%C" => channel.Name,
+
                         "%p" => channel.Position?.ToString(CultureInfo.InvariantCulture) ?? "0",
                         "%P"
                             => channel.Parent?.Position?.ToString(CultureInfo.InvariantCulture)
                                 ?? "0",
+
                         "%a"
                             => after?.ToDate().ToString("yyyy-MM-dd", CultureInfo.InvariantCulture)
                                 ?? "",
@@ -172,12 +186,12 @@ private static string FormatPath(
                                 "yyyy-MM-dd",
                                 CultureInfo.InvariantCulture
                             ),
+
                         "%%" => "%",
                         _ => m.Value
                     }
                 )
         );
-    }
 
     private static string GetOutputBaseFilePath(
         Guild guild,

DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs

@@ -280,7 +280,7 @@ protected override async ValueTask VisitMentionAsync(
         else if (mention.Kind == MentionKind.Channel)
         {
             var channel = mention.TargetId?.Pipe(_context.TryGetChannel);
-            var symbol = channel?.Kind.IsVoice() == true ? "🔊" : "#";
+            var symbol = channel?.IsVoice == true ? "🔊" : "#";
             var name = channel?.Name ?? "deleted-channel";
 
             _buffer.Append(

DiscordChatExporter.Core/Exporting/HtmlMessageWriter.cs

@@ -30,22 +30,22 @@ private bool CanJoinGroup(Message message)
         if (_messageGroup.LastOrDefault() is not { } lastMessage)
             return true;
 
-        // Reply messages cannot join existing groups because they need to appear first
-        if (message.Kind == MessageKind.Reply)
+        // Reply-like messages cannot join existing groups because they need to appear first
+        if (message.IsReplyLike)
             return false;
 
         // Grouping for system notifications
-        if (message.Kind.IsSystemNotification())
+        if (message.IsSystemNotification)
         {
             // Can only be grouped with other system notifications
-            if (!lastMessage.Kind.IsSystemNotification())
+            if (!lastMessage.IsSystemNotification)
                 return false;
         }
         // Grouping for normal messages
         else
         {
             // Can only be grouped with other normal messages
-            if (lastMessage.Kind.IsSystemNotification())
+            if (lastMessage.IsSystemNotification)
                 return false;
 
             // Messages must be within 7 minutes of each other