Skip to content

Conversation

@Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 23, 2025

Copilot AI review requested due to automatic review settings November 23, 2025 17:40
@Tyrrrz Tyrrrz added the bug Something isn't working label Nov 23, 2025
@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.46%. Comparing base (5a1a7ff) to head (d4807cd).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
GitHubActionsTestLogger/MtpLogger.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   84.70%   84.46%   -0.24%     
==========================================
  Files          23       23              
  Lines         719      721       +2     
  Branches       84       85       +1     
==========================================
  Hits          609      609              
- Misses         57       58       +1     
- Partials       53       54       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot finished reviewing on behalf of Tyrrrz November 23, 2025 17:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #41 by adding logic to skip processing of test node updates for tests that haven't reached a concluded state. The logger now ignores tests in Discovered or InProgress states, preventing incomplete test information from being added to results and reported to GitHub Actions.

Key Changes

  • Added early return in ConsumeAsync to filter out non-concluded test states before processing test results
  • Only tests with final states (Passed, Failed, Error, Timeout, Skipped, Cancelled) are now processed and reported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit c7223f2 into master Nov 23, 2025
20 checks passed
@Tyrrrz Tyrrrz deleted the skip-discovered-inprogress-tests branch November 23, 2025 18:07
This was referenced Nov 23, 2025
This was referenced Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants