Skip to content

Commit

Permalink
[rfw][ci] Skip failing rfw golden tests (flutter#7170)
Browse files Browse the repository at this point in the history
See flutter#151995

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [ ] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [ ] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style], or this PR is [exempt from
CHANGELOG changes].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
  • Loading branch information
LouiseHsu authored Jul 18, 2024
1 parent 1d37e25 commit 68b6a68
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 7 deletions.
4 changes: 3 additions & 1 deletion packages/rfw/test/argument_decoders_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/argument_decoders_test.containers.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
expect(find.byType(DecoratedBox), findsNWidgets(6));
const String matrix = kIsWeb ? '1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1'
Expand Down
24 changes: 18 additions & 6 deletions packages/rfw/test/material_widgets_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,19 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.scaffold.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);

await tester.tap(find.byType(DropdownButton<Object>).first);
await tester.pumpAndSettle();
await expectLater(
find.byType(MaterialApp),
matchesGoldenFile('goldens/material_test.dropdown.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
// Tap on the second item.
await tester.tap(find.text('bar'));
Expand Down Expand Up @@ -289,7 +293,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.button_bar_properties.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);

// Update the surface size for ButtonBar to overflow.
Expand Down Expand Up @@ -361,7 +367,9 @@ void main() {
find.byType(RemoteWidget),
matchesGoldenFile(
'goldens/material_test.overflow_bar_resembles_button_bar.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
});

Expand Down Expand Up @@ -436,7 +444,9 @@ void main() {
find.byType(RemoteWidget),
matchesGoldenFile(
'goldens/material_test.overflow_bar_properties.overflow.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
});

Expand Down Expand Up @@ -566,7 +576,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.material_properties.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);

runtime.update(testName, parseLibraryFile('''
Expand Down

0 comments on commit 68b6a68

Please sign in to comment.