Update entrypoint.sh #696
Merged
Update entrypoint.sh #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
about gosu behaviour, it looking for local "existed" UID, i found it become blank. That is our issue, so updating our entrypoint to change existed user "youtube" UID and GID to match compose request, will make gosu correctly find use UID:GID as it existed.
Closed
Tzahi12345
approved these changes
Jul 3, 2022
There was a problem hiding this comment.
Verified working here: #671 (comment)
Approving! Thank you so much for this PR!!
Tzahi12345
added a commit
that referenced
this pull request
Jul 5, 2022
|
Add some reference for tracking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about gosu behaviour, it looking for local "existed" UID,
exec gosu UID:GID -> gosu looking for custom UID:GID -> gosu can't find it -> UID:GID became blank -> exec gosu blankUID:blankGID -> permission denied.That is our issue, so updating our entrypoint to change existed user "youtube" to match custom UID and GID, will make gosu correctly use UID:GID as it existed.
Related #671