Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdf-chrome derivative #248

Merged
merged 9 commits into from
May 2, 2024
Merged

Conversation

jtruitt1
Copy link
Contributor

@jtruitt1 jtruitt1 commented Mar 7, 2024

Type of Contribution

  • Bugfix (non-breaking change which fixes an issue)
  • New component
  • Refactoring (no functional changes)
  • Documentation-only

What does this implement/fix? Explain your changes.

  • Update outdated Chrome CLI parameter
  • Expand list of possible chromes to include default name for Chrome CLI on macOS
  • Add documentation for macOS users to add Chrome CLI to their PATH

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to the develop branch. Don't PR to main!
  • This contribution has sufficient documentation
  • Tests for the changes have been added
  • All tests pass

How has this been tested?

Operating System: macOS Ventura 13.5
Python Version: Python 3.9.5

Licensing

  • I agree that the Mailbag Project and the University at Albany, SUNY can release this code under the MIT license.

@gwiedeman
Copy link
Collaborator

I don't have access to a mac, so I can't easily test this. Its odd to me that Google\ Chrome would work, but this is only additive, so I'm fine merging it, as even if its not the ideal install or whatever if it helped you it should help someone else.

Thanks also for catching the --no-pdf-header-footer flag change!

@gwiedeman gwiedeman merged commit a4af068 into UAlbanyArchives:develop May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants