Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git submodules #148

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Use git submodules #148

merged 1 commit into from
Jul 7, 2022

Conversation

stweil
Copy link
Member

@stweil stweil commented Jul 6, 2022

Signed-off-by: Stefan Weil sw@weilnetz.de

@stweil
Copy link
Member Author

stweil commented Jul 6, 2022

This pull requests conflicts with pull request #144 which should be merged first.

@stweil
Use git submodules
c54399f 
Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Copy link
Member Author

stweil commented Jul 7, 2022

I rebased now and fixed the merge conflicts.

kba
kba approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM that makes it much easier to maintain/debug.

@stweil stweil merged commit b4c1339 into master Jul 7, 2022
@stweil stweil deleted the submodules branch July 7, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stweil @kba