Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added in code comments #95

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix: added in code comments #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/passwordler/decrypt_password.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ def decrypt_password(encrypted_password, random_seed = 123):
decryption = original.copy()
random.shuffle(decryption)

# generate a key map for decryption
keyMap = getKeyMap(decryption, isDecryption=True)
decrypted_pass = []

# decrypt password with key map
for character in encrypted_password:
if character in keyMap:
decrypted_pass.append(keyMap[character])
Expand Down
2 changes: 2 additions & 0 deletions src/passwordler/encrypt_password.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ def encrypt_password(password, random_seed=123):
encryption = original.copy()
random.shuffle(encryption)

# generate a key map for encryption
keyMap = getKeyMap(encryption)
encrypted_pass = []

# encrypt password with key map
for character in password:
if character in original:
encrypted_pass.append(keyMap[character])
Expand Down
7 changes: 6 additions & 1 deletion src/passwordler/password_strength.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def password_strength(password):
elif password == '':
raise ValueError("'password' cannot be an empty string")

# collect information on the password
count_uppercase = len(re.findall("[A-Z]", password))
count_numbers = len(re.findall('[0-9]', password))
count_special_chars = len(re.findall('[!-/:-@\\[-`{-~]', password))
Expand All @@ -34,10 +35,14 @@ def password_strength(password):
'baseball', 'dragon', 'football', '1234567', 'monkey', 'letmein', 'abc123',
'111111', 'mustang', 'access', 'shadow', 'master', 'michael', 'superman',
'696969', '123123', 'batman', 'trustno1']


# conditions for strong password
if length >= 12 and count_uppercase >= 1 and count_numbers >= 1 and count_special_chars >= 1 and password not in common_passwords:
return 'Your password is: Strong'

# conditions for good password
elif length >= 8 and (count_uppercase + count_numbers + count_special_chars) >= 2 and password not in common_passwords:
return 'Your password is: Good'

else:
return 'Your password is: Weak'
Loading