Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Implement Sensor Classes #60

Merged
merged 23 commits into from
Dec 8, 2023

Conversation

chrischang5
Copy link
Contributor

@chrischang5 chrischang5 commented Nov 18, 2023

Description

Verification

  • Added and run tests in tests/unit/common/test_wind_sensor.py and tests/unit/common/test_gps_sensor.py

Resources

chrischang5 and others added 12 commits November 4, 2023 16:07
* Bump UBCSailbot/sailbot_workspace from 1.4.2 to 1.4.7

Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.2 to 1.4.7.
- [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases)
- [Commits](UBCSailbot/sailbot_workspace@v1.4.2...v1.4.7)

---
updated-dependencies:
- dependency-name: UBCSailbot/sailbot_workspace
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update secret name

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick Creighton <pcreighton429@gmail.com>
Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.7 to 1.4.8.
- [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases)
- [Commits](UBCSailbot/sailbot_workspace@v1.4.7...v1.4.8)

---
updated-dependencies:
- dependency-name: UBCSailbot/sailbot_workspace
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.8 to 1.5.1.
- [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases)
- [Commits](UBCSailbot/sailbot_workspace@v1.4.8...v1.5.1)

---
updated-dependencies:
- dependency-name: UBCSailbot/sailbot_workspace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@chrischang5 chrischang5 changed the title User/chrischang5/53 implement sensor class Implement Sensor Classes Nov 25, 2023
@chrischang5 chrischang5 marked this pull request as ready for review November 25, 2023 23:34
@chrischang5
Copy link
Contributor Author

fighting against CI, type hinting, and linting is so frustrating and has resulted in more bugs >:(.

Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You managed to make a very elegant implementation of the sensor classes. This is a job well done!

I just had a few comments, but feel free to tag me/reply to any of these comments if you have further questions or when responding to my questions.

boat_simulator/common/sensors.py Show resolved Hide resolved
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
boat_simulator/common/sensors.py Show resolved Hide resolved
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
tests/unit/common/test_sensors.py Outdated Show resolved Hide resolved
tests/unit/common/test_sensors.py Outdated Show resolved Hide resolved
tests/unit/common/test_sensors.py Outdated Show resolved Hide resolved
@chrischang5 chrischang5 self-assigned this Dec 8, 2023
@chrischang5 chrischang5 merged commit 0ccb48c into main Dec 8, 2023
12 checks passed
@chrischang5 chrischang5 deleted the user/chrischang5/53-implement-sensor-class branch December 8, 2023 08:02
@chrischang5 chrischang5 restored the user/chrischang5/53-implement-sensor-class branch February 10, 2024 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Sensor Class
3 participants