This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump UBCSailbot/sailbot_workspace from 1.4.2 to 1.4.7 Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.2 to 1.4.7. - [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases) - [Commits](UBCSailbot/sailbot_workspace@v1.4.2...v1.4.7) --- updated-dependencies: - dependency-name: UBCSailbot/sailbot_workspace dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update secret name --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick Creighton <pcreighton429@gmail.com>
Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.7 to 1.4.8. - [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases) - [Commits](UBCSailbot/sailbot_workspace@v1.4.7...v1.4.8) --- updated-dependencies: - dependency-name: UBCSailbot/sailbot_workspace dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.8 to 1.5.1. - [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases) - [Commits](UBCSailbot/sailbot_workspace@v1.4.8...v1.5.1) --- updated-dependencies: - dependency-name: UBCSailbot/sailbot_workspace dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chrischang5
changed the title
User/chrischang5/53 implement sensor class
Implement Sensor Classes
Nov 25, 2023
chrischang5
commented
Nov 25, 2023
fighting against CI, type hinting, and linting is so frustrating and has resulted in more bugs >:(. |
DFriend01
suggested changes
Nov 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You managed to make a very elegant implementation of the sensor classes. This is a job well done!
I just had a few comments, but feel free to tag me/reply to any of these comments if you have further questions or when responding to my questions.
DFriend01
reviewed
Dec 8, 2023
DFriend01
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verification
tests/unit/common/test_wind_sensor.py
andtests/unit/common/test_gps_sensor.py
Resources