Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Sensors: Add delay model #75

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Sensors: Add delay model #75

wants to merge 33 commits into from

Conversation

chrischang5
Copy link
Contributor

@chrischang5 chrischang5 commented Feb 25, 2024 •
edited
Loading

Description

Add a delay modeling option, which just delays registering values in the sensor by a single update cycle. "Registering" refers to storing a value in the sensor.

Delay model will delay sensor value updates by one update cycle:
    - Sensor has initial data x0 at t = 0
    - Sensor provided new data x_1 at t = 1
    - Sensor provided new data x_2 at t = 2. At t = 2, x1 is registered into the sensor.
    - Sensor provided new data x_i at t = i. At t = i, x_{i-1} is registered into the sensor.

Verification

  • Run tests in src/boat_simulator/tests/unit/common/test_gps_sensor.py and src/boat_simulator/tests/unit/common/test_wind_sensor.py

Resources

  • N/A

chrischang5 and others added 24 commits November 4, 2023 16:07
@chrischang5
Sensor: Create Sensor parent class and GPS and WindSensor child classes
3bcfdea
@chrischang5
Sensor: Refactor code
6bbdb72
@chrischang5
Sensor: Implement WindSensor and GPS classes
83b105a
@chrischang5
Sensor: Add tests and code cleanup
ed70153
@dependabot @patrick-5546 @chrischang5
Bump UBCSailbot/sailbot_workspace from 1.4.2 to 1.4.7 (#55)
9e53e3e 
* Bump UBCSailbot/sailbot_workspace from 1.4.2 to 1.4.7

Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.2 to 1.4.7.
- [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases)
- [Commits](UBCSailbot/sailbot_workspace@v1.4.2...v1.4.7)

---
updated-dependencies:
- dependency-name: UBCSailbot/sailbot_workspace
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update secret name

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Patrick Creighton <pcreighton429@gmail.com>
@patrick-5546 @chrischang5
Make ubcsailbotsoftware a code owner (#57)
c9b9971
@dependabot @chrischang5
Bump UBCSailbot/sailbot_workspace from 1.4.7 to 1.4.8 (#56)
6f65c06 
Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.7 to 1.4.8.
- [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases)
- [Commits](UBCSailbot/sailbot_workspace@v1.4.7...v1.4.8)

---
updated-dependencies:
- dependency-name: UBCSailbot/sailbot_workspace
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@patrick-5546 @chrischang5
Make ubcsailbotsoftware code owner only for test.yml (#58)
091154a
@dependabot @chrischang5
Bump UBCSailbot/sailbot_workspace from 1.4.8 to 1.5.1 (#59)
5d999f0 
Bumps [UBCSailbot/sailbot_workspace](https://github.com/ubcsailbot/sailbot_workspace) from 1.4.8 to 1.5.1.
- [Release notes](https://github.com/ubcsailbot/sailbot_workspace/releases)
- [Commits](UBCSailbot/sailbot_workspace@v1.4.8...v1.5.1)

---
updated-dependencies:
- dependency-name: UBCSailbot/sailbot_workspace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@chrischang5
Sensor: Ignore redef mypy error
a57a9c2
@chrischang5
Sensor: Create custom type to have cleaner type hinting
ba9cd83
@chrischang5
Sensors: Complete tests and resolve typing errors
31f458c
@chrischang5
Merge branch 'main' into user/chrischang5/53-implement-sensor-class
3dae5ba
@chrischang5
Try to make CI happy
65c42e2
@chrischang5
Try to make CI happy
96c9405
@chrischang5
Fix bugs :(
6a63fac
@chrischang5
Sensor: make syntax consistent
f8f6a61
@chrischang5
Fix bugs
b11f176
@chrischang5
Sensors: add docstrings, add support to implicitly or explicitly set …
893d4b0 
…noisemakers in sensors
@chrischang5
Sensors: finish docstrings
a8688fb
@chrischang5
Merge branch 'main' into user/chrischang5/53-implement-sensor-class
7c92df1
@chrischang5
fixed an oops
2f6cc27
@chrischang5
Sensor: Add todo for dimensionality checking
2609bcc
@chrischang5
Sensors: Complete delay implementation and tests
770df02
@chrischang5
Copy link
Contributor Author

I'll fix the conflicts tomorrow.

DFriend01
DFriend01 suggested changes Mar 2, 2024
View reviewed changes
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
boat_simulator/common/sensors.py Outdated Show resolved Hide resolved
DFriend01
DFriend01 suggested changes Mar 9, 2024
View reviewed changes
boat_simulator/common/sensors.py Show resolved Hide resolved
boat_simulator/common/sensors.py Show resolved Hide resolved
@chrischang5 chrischang5 mentioned this pull request Mar 15, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DFriend01 DFriend01 DFriend01 requested changes

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Realism to Simulated Sensor Data
3 participants
@chrischang5 @DFriend01 @patrick-5546