20 lookup table class

[alberto-escobar]

Description

• Resolves Lookup Table Class #20

Verification

• Created testing suite in lut_test, and has passing results when running tests

Resources

• None

[DFriend01]

Great work, just a few more comments on your LUT class and tests.

[alberto-escobar]

@DFriend01 All issues resolved, one question I have:
Are the failed tests going to be a problem?

[DFriend01]

@DFriend01 All issues resolved, one question I have: Are the failed tests going to be a problem?

@alberto-escobar If the tests pass on your local machine, then this is probably an infrastructure problem. I'll look into it this weekend.

However, the flake8 test should be passing. Make sure that the Python autoformatter is enabled. You can also run the flake8 task in sailbot workspace to diagnose the problem on your end and resolve the lining errors yourself, or at least figure out where the problem is so you can apply the autoformatter there.

[alberto-escobar]

@DFriend01 All issues resolved, one question I have: Are the failed tests going to be a problem?

@alberto-escobar If the tests pass on your local machine, then this is probably an infrastructure problem. I'll look into it this weekend.

However, the flake8 test should be passing. Make sure that the Python autoformatter is enabled. You can also run the flake8 task in sailbot workspace to diagnose the problem on your end and resolve the lining errors yourself, or at least figure out where the problem is so you can apply the autoformatter there.

@DFriend01 I figured out the problem, in test_lut.py I added:

assert math.isclose(testLUT(50000), 5.75)

where ever there was an instance of a LUT object created but never used. This cleared up flake8 errors.

I also had to add the following logic to __linearInterpolation in lut.py to mitigate an error of np.interp returning an NDArray:

    def __linearInterpolation(self, x: Scalar) -> float:
        output = np.interp(x, self.x, self.y)
        if isinstance(output, np.ndarray):
            raise ValueError(
                "linear interpolation returned a NDArray when it should have returned a float"
            )
        return output

I made a unit test for this in test_lut called test_linear_interpolation_exception

[DFriend01]

The warnings seemed to have been resolved. Great work!