Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish ROS package actions sailbot workspace component #100

Merged
merged 15 commits into from
Mar 24, 2023

Conversation

colinli02
Copy link
Contributor

@colinli02 colinli02 commented Feb 26, 2023

Description

To Do

  • Add argument for running rebuild docs job (only run if page used in docs site) - resolve merge conflict while doing so

Verification

@patrick-5546 patrick-5546 added path Pathfinding team infrastructure labels Feb 26, 2023
@patrick-5546 patrick-5546 changed the title User/colinli02/11 publish ros package actions final Publish ROS package actions sailbot workspace component Feb 26, 2023
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a bug, see the biggest comment below

@patrick-5546
Copy link
Member

patrick-5546 commented Mar 12, 2023

New things to do

<Moved to do's to PR description>

@patrick-5546
Copy link
Member

patrick-5546 commented Mar 13, 2023

  • Add argument for running rebuild docs job (only run if page used in docs site) - resolve merge conflict while doing so

Adding detail for the first to do.

Add a required input called rebuild-docs of type boolean. This should be true for sailbot_workspace and false for network_systems.

Then you can add an if condition to the rebuild-docs job:

      if: ${{ inputs.rebuild-docs}}

@colinli02 colinli02 force-pushed the user/colinli02/11-Publish-ROS-package-actions_FINAL branch 3 times, most recently from 3211590 to 57c2088 Compare March 18, 2023 03:18
@colinli02
Copy link
Contributor Author

PR comments resolved. Sailbot_workspace tests.yml looks fine:
Note: clang-tidy seems to run longer than normal
image

@patrick-5546
Copy link
Member

clang-tidy seems to run longer than normal

Currently this is expected, but I created an issue addressing this:

@patrick-5546 patrick-5546 mentioned this pull request Mar 18, 2023
1 task
@colinli02 colinli02 force-pushed the user/colinli02/11-Publish-ROS-package-actions_FINAL branch from 57c2088 to c740e2f Compare March 18, 2023 16:12
@colinli02 colinli02 force-pushed the user/colinli02/11-Publish-ROS-package-actions_FINAL branch from c740e2f to a7d76c9 Compare March 18, 2023 16:19
@colinli02
Copy link
Contributor Author

colinli02 commented Mar 18, 2023

New things to do

  • Add argument for running rebuild docs job (only run if page used in docs site) - resolve merge conflict while doing so

Adding detail for the first to do.

Add a required input called rebuild-docs of type boolean. This should be true for sailbot_workspace and false for network_systems.

Then you can add an if condition to the rebuild-docs job:

      if: ${{ inputs.rebuild-docs}}

Do you want it like this? From my understanding you just want a string to be true or false if rebuild-docs is needed

    if: github.event_name == 'push' && github.ref == 'refs/heads/main' && ${{ inputs.rebuild-docs}} == 'true'

if this is the case, both branches (PRs) are done. Requires final review before making changes and then I can switch to @main for final merge.

Thanks!
Edit: Patrick confirms bool is fine.

<Moved to do's to issue>

@colinli02 colinli02 requested a review from patrick-5546 March 18, 2023 16:36
@colinli02 colinli02 force-pushed the user/colinli02/11-Publish-ROS-package-actions_FINAL branch from e205fc7 to 38dab20 Compare March 18, 2023 17:09
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR!

colinli02 added a commit that referenced this pull request Mar 24, 2023
@colinli02 colinli02 merged commit ebb2c1e into main Mar 24, 2023
@patrick-5546 patrick-5546 deleted the user/colinli02/11-Publish-ROS-package-actions_FINAL branch March 24, 2023 23:32
colinli02 added a commit that referenced this pull request Mar 25, 2023
* Changes based on #100 Added.

* Added CI badges for 2 workflow .yml files 'build images' and 'tests'

* Remove Build Images CI badge

---------

Co-authored-by: Patrick Creighton <pcreighton429@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure path Pathfinding team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish ROS package actions
2 participants