-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish ROS package actions sailbot workspace component #100
Publish ROS package actions sailbot workspace component #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found a bug, see the biggest comment below
New things to do <Moved to do's to PR description> |
…lish-ROS-package-actions_FINAL
Did not do ${{ github.event.repository.name }} yet
…ttps://github.com/UBCSailbot/sailbot_workspace into user/colinli02/11-Publish-ROS-package-actions_FINAL
Adding detail for the first to do. Add a required input called Then you can add an if condition to the if: ${{ inputs.rebuild-docs}} |
…into user/colinli02/11-Publish-ROS-package-actions_FINAL # Conflicts: # .github/workflows/tests.yml
…ttps://github.com/UBCSailbot/sailbot_workspace into user/colinli02/11-Publish-ROS-package-actions_FINAL
3211590
to
57c2088
Compare
Currently this is expected, but I created an issue addressing this: |
57c2088
to
c740e2f
Compare
c740e2f
to
a7d76c9
Compare
Do you want it like this? From my understanding you just want a string to be true or false if if: github.event_name == 'push' && github.ref == 'refs/heads/main' && ${{ inputs.rebuild-docs}} == 'true' if this is the case, both branches (PRs) are done. Requires final review before making changes and then I can switch to Thanks! <Moved to do's to issue> |
e205fc7
to
38dab20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this PR!
* Changes based on #100 Added. * Added CI badges for 2 workflow .yml files 'build images' and 'tests' * Remove Build Images CI badge --------- Co-authored-by: Patrick Creighton <pcreighton429@gmail.com>
Description
To Do
Verification