-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Boat Simulator and Enhance Build Tasks #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out the new build task: it works perfectly for one package, but not multiple packages. I think this is because packages are separated by spaces, which in bash delimits arguments. My suggestion would just be to keep it simple: delete the packages task input and use the package. I don't think it's necessary to be able to specify multiple packages to build, would be easier just build everything using the regular build task.
Also flake8 started failing, I'm not sure what changed.
Wait to merge until this issue is resolved: It should resolve the linting errors in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will approve once comments resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will pass once you merge in your boat_simulator PR and rerun failed jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more idea that I had regarding the build tasks: incorporating quick_build.sh
. There are multiple ways that this can be done, I'll let you decide what to do.
What do you think about combining quick_build.sh and build.sh by adding an argument to build.sh? Also if we keep quick_build.sh I think we should rename it build_quick.sh so that it is next to build.sh alphabetically. The deployment README/script would have to be updated accordingly.
If you don't have time to do this right now can you write an issue for this?
Description
Related to this issue. Adds the boat simulator and modifies the build script.
The following was modified:
Build All
is the oldBuild
taskBuild
task prompts for specific packages to be builtVerification
CTRL + SHIFT + B
brings up bothBuild All
andBuild
tasks as build options