Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker compose #116

Merged
merged 5 commits into from
May 22, 2023
Merged

Use docker compose #116

merged 5 commits into from
May 22, 2023

Conversation

patrick-5546
Copy link
Member

Description

Make the dev container use docker compose. Previously, it was built on .devcontainer/Dockerfile. Now it is built on .devcontainer/docker-compose.yml, which builds the dockerfile. Using docker compose allows the dev container to run multiple images.

Verification

  • Rebuild dev container locally

Resource

@patrick-5546
Copy link
Member Author

@hhenry01 FYI see the first commit. We previously discussed that the dev container doesn't need to see CAN, as the mocks won't be using VCAN.

Overall plan is to refactor #107 into multiple smaller PRs, the first of which is this one.

@patrick-5546 patrick-5546 enabled auto-merge (squash) May 22, 2023 19:22
@patrick-5546 patrick-5546 self-assigned this May 22, 2023
@patrick-5546 patrick-5546 added sim Boat Simulator team infrastructure labels May 22, 2023
@patrick-5546 patrick-5546 merged commit a8a6229 into main May 22, 2023
@patrick-5546 patrick-5546 deleted the user/patrick-5546/use-docker-compose branch May 22, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure sim Boat Simulator team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant