Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local pathfinding repo and improve python infra #130

Merged
merged 29 commits into from
Jun 8, 2023
Merged

Add local pathfinding repo and improve python infra #130

merged 29 commits into from
Jun 8, 2023

Conversation

patrick-5546
Copy link
Member

@patrick-5546 patrick-5546 commented Jun 5, 2023 •
edited
Loading

Description

Python infrastructure improvements made:

  • Format on save
  • Fix build warning
  • Change line length to 99
  • Align ament lint tasks and github action job
  • Remove ament_pep257 linter: I don't like the docstrings format it enforces; use Google docstrings template generated by extension instead
  • Configure timezone to "America/Vancouver"
  • Customize ROS log format

Verification

  • Tested in conjunction with writing the skeleton code for the local pathfinding repository

@patrick-5546 patrick-5546 self-assigned this Jun 5, 2023
@patrick-5546 patrick-5546 added enhancement New feature or request ctrl Controller team infrastructure labels Jun 5, 2023
@patrick-5546 patrick-5546 mentioned this pull request Jun 6, 2023
Closed
7 tasks
@patrick-5546 patrick-5546 force-pushed the user/patrick-5546/setup-local-pathfinding branch from e32fef8 to 3d09d64 Compare June 8, 2023 10:12
@patrick-5546 patrick-5546 force-pushed the user/patrick-5546/setup-local-pathfinding branch from 3b64c71 to f1efb91 Compare June 8, 2023 10:32
@patrick-5546 patrick-5546 force-pushed the user/patrick-5546/setup-local-pathfinding branch from f1efb91 to b44e484 Compare June 8, 2023 10:35
@patrick-5546 patrick-5546 marked this pull request as ready for review June 8, 2023 10:46
@patrick-5546 patrick-5546 changed the title Add local pathfinding repo and improve python infrastructure Add local pathfinding repo and improve python infra Jun 8, 2023
@patrick-5546 patrick-5546 removed the enhancement New feature or request label Jun 8, 2023
@patrick-5546 patrick-5546 merged commit e882adb into main Jun 8, 2023
@patrick-5546 patrick-5546 removed the ctrl Controller team label Jun 9, 2023
@patrick-5546 patrick-5546 deleted the user/patrick-5546/setup-local-pathfinding branch June 11, 2023 22:18
@patrick-5546 patrick-5546 mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@patrick-5546 patrick-5546

Labels
infrastructure
Projects
SOFT Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patrick-5546