Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Run virtual iridium before tests (#184)" #185

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

hhenry01
Copy link
Member

@hhenry01 hhenry01 commented Nov 3, 2023

Description

  • Resolves #issue

Verification

  • [ ]

Resources

@hhenry01 hhenry01 added the bug Something isn't working label Nov 3, 2023
@hhenry01 hhenry01 force-pushed the user/hhenry01/run_virtual_iridium_with_tests branch from 85c75e2 to 8480121 Compare November 3, 2023 21:22
@hhenry01 hhenry01 marked this pull request as ready for review November 3, 2023 21:41
@hhenry01 hhenry01 enabled auto-merge (squash) November 3, 2023 21:43
@hhenry01 hhenry01 disabled auto-merge November 3, 2023 21:49
@hhenry01 hhenry01 marked this pull request as draft November 3, 2023 21:53
@patrick-5546
Copy link
Member

@hhenry01 hhenry01 force-pushed the user/hhenry01/run_virtual_iridium_with_tests branch from 8480121 to 77d16f1 Compare November 3, 2023 23:09
@hhenry01
Copy link
Member Author

hhenry01 commented Nov 3, 2023

Properly fixing it requires a change in network_systems. But I can't push network_systems fix while sailbot_workspace is broken, so I'm reverting the commit first.

@hhenry01 hhenry01 marked this pull request as ready for review November 3, 2023 23:12
@hhenry01 hhenry01 enabled auto-merge (squash) November 3, 2023 23:12
@patrick-5546 patrick-5546 changed the title Fix test script Revert "Run virtual iridium before tests (#184)" Nov 3, 2023
@hhenry01 hhenry01 merged commit 7c76b8e into main Nov 4, 2023
@hhenry01 hhenry01 deleted the user/hhenry01/run_virtual_iridium_with_tests branch November 4, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants