Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Fluid Force Computation class #337

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Create Fluid Force Computation class #337

merged 7 commits into from
Mar 23, 2024

Conversation

tanmaythakral
Copy link
Contributor

@DFriend01 DFriend01 added the sim Boat Simulator team label Mar 22, 2024
@DFriend01
Copy link
Contributor

Looks great! Can you add one more picture where the apparent wind lies in the first quadrant?

DFriend01
DFriend01 requested changes Mar 22, 2024
View reviewed changes
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_forces.py Show resolved Hide resolved
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
src/boat_simulator/boat_simulator/nodes/physics_engine/fluid_forces.py Outdated Show resolved Hide resolved
src/boat_simulator/package.xml Outdated Show resolved Hide resolved
src/boat_simulator/tests/unit/nodes/physics_engine/test_fluid_forces.py Show resolved Hide resolved
DFriend01
DFriend01 approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failing jobs, but once you resolve those feel free to merge this PR. Great work!

@tanmaythakral tanmaythakral enabled auto-merge (squash) March 23, 2024 21:15
@tanmaythakral tanmaythakral merged commit e2b3672 into main Mar 23, 2024
13 checks passed
@tanmaythakral tanmaythakral deleted the tanmaythakral/307-fluid-forces branch March 23, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DFriend01 DFriend01 DFriend01 approved these changes

Assignees
No one assigned
Labels
sim Boat Simulator team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Fluid Force Computation class
2 participants
@tanmaythakral @DFriend01