-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter datapoints by timestamp - Timestamp Filter - Issue #279 #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel! Again, awesome work 😄
I left some comments, mostly dealing with style guidelines.
Could we also implement filtering with the map? Right now, it only filters the data in the data dashboard. A very similar implementation should be done in the MapContainer
. This should include:
- The map itself.
- The distance travelled
- And the compass (taking the latest heading depending on how we filter things).
src/website/views/components/TimestampFilter/TimestampFilter.tsx
Outdated
Show resolved
Hide resolved
Fixes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving comments to refactor some implementation details
Description
Verification
Resources
Note:
src/website/tests/simulation/simulation.py
(maybe needs to be changed)?