Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter datapoints by timestamp - Timestamp Filter - Issue #279 #338

Merged
merged 23 commits into from
Apr 4, 2024
Merged

Conversation

dk1702
Copy link
Contributor

@dk1702 dk1702 commented Mar 23, 2024

Description

Verification

  • [ ]

Resources

Note:

  • plz double check the db name under src/website/tests/simulation/simulation.py (maybe needs to be changed)?

@dk1702 dk1702 requested a review from jahn18 as a code owner March 23, 2024 06:31
@dk1702 dk1702 linked an issue Mar 23, 2024 that may be closed by this pull request
@patrick-5546 patrick-5546 added the web Website team label Mar 23, 2024
Copy link
Member

@jahn18 jahn18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! Again, awesome work 😄

I left some comments, mostly dealing with style guidelines.

Could we also implement filtering with the map? Right now, it only filters the data in the data dashboard. A very similar implementation should be done in the MapContainer. This should include:

  • The map itself.
  • The distance travelled
  • And the compass (taking the latest heading depending on how we filter things).

src/website/stores/Timestamp/TimestampActions.ts Outdated Show resolved Hide resolved
src/website/stores/Timestamp/TimestampReducers.ts Outdated Show resolved Hide resolved
src/website/stores/Timestamp/TimestampReducers.ts Outdated Show resolved Hide resolved
src/website/stores/Timestamp/TimestampActions.ts Outdated Show resolved Hide resolved
src/website/stores/Timestamp/TimestampSagas.ts Outdated Show resolved Hide resolved
src/website/stores/Timestamp/TimestampTypes.ts Outdated Show resolved Hide resolved
src/website/views/DashboardContainer.tsx Outdated Show resolved Hide resolved
src/website/views/DashboardContainer.tsx Outdated Show resolved Hide resolved
src/website/views/DashboardContainer.tsx Outdated Show resolved Hide resolved
src/website/views/DashboardContainer.tsx Outdated Show resolved Hide resolved
@jahn18
Copy link
Member

jahn18 commented Mar 30, 2024

Fixes:

  • We want to filter AISShips
    • Add another document for AISShips with varying lat/lng points (just increment everything by 0.1)
  • When filtering into the future, we should see nothing on the map.

Copy link
Member

@jahn18 jahn18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving comments to refactor some implementation details

src/website/views/MapsContainer.tsx Outdated Show resolved Hide resolved
src/website/views/DashboardContainer.tsx Outdated Show resolved Hide resolved
src/website/views/DashboardContainer.tsx Outdated Show resolved Hide resolved
src/website/views/MapsContainer.tsx Outdated Show resolved Hide resolved
src/website/views/MapsContainer.tsx Outdated Show resolved Hide resolved
src/website/views/MapsContainer.tsx Outdated Show resolved Hide resolved
src/website/views/MapsContainer.tsx Outdated Show resolved Hide resolved
src/website/views/components/BoatCompass/BoatCompass.tsx Outdated Show resolved Hide resolved
src/website/views/MapsContainer.tsx Outdated Show resolved Hide resolved
@jahn18 jahn18 enabled auto-merge (squash) April 4, 2024 09:53
@jahn18 jahn18 merged commit e6b204c into main Apr 4, 2024
11 checks passed
@jahn18 jahn18 deleted the issue279 branch April 4, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web Website team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter datapoints by timestamp
3 participants