Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Docker volume for ROS 1 workspace #44

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

Harvir14
Copy link
Contributor

This branch resolves #37 .

@Harvir14 Harvir14 requested a review from patrick-5546 October 22, 2022 06:49
@Harvir14 Harvir14 self-assigned this Oct 22, 2022
@patrick-5546 patrick-5546 added infrastructure sim Boat Simulator team labels Oct 22, 2022
Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, feel free to merge

@patrick-5546 patrick-5546 changed the title Harvir/37 ros1 workspace volume Create Docker volume for ROS 1 workspace Oct 22, 2022
@patrick-5546
Copy link
Member

patrick-5546 commented Oct 22, 2022

Updated the PR title, no need to put author and issue number, as it is stated in other parts of the PR. Also added some relevant labels.

@patrick-5546 patrick-5546 merged commit c28546f into main Oct 22, 2022
@patrick-5546 patrick-5546 deleted the harvir/37-ROS1_workspace_volume branch October 22, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure sim Boat Simulator team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make catkin_ws/src a Docker volume
2 participants