-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to run container via docker cli #94
Add script to run container via docker cli #94
Conversation
73232e6
to
162660d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: does this script only work for the RPi, or can it be used on any computer (for example if you don't want to use VS Code)?
Works on any computer. A few bells and whistles prevent it from being 1:1 like switching the user to ros and copying config files into the container, but all essential functions are present. Again, this is all doable and not hard, I just didn't see the point if the goal is just to make it runnable on the rpi. |
Would like to see this running on the Rpi, specifically how its performance compares to your laptop. I will turn on EDC PC tomorrow. |
bf1b23f
to
a8987f5
Compare
Works on rpi. Added a quick_build script for convenience. Building with it on my laptop takes ~14-16 seconds after a purging while it takes 2 min on the rpi. |
Can you login to the ubcsailbotsoftware GitHub account on the rpi so that we can push quick fixes? It's probably easiest to set this up outside the container and login using a PAT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General notes:
- I think we can move
deployment_scripts/
to.devcontainer/
so that everything related to docker is there - Would be good to add a README in
deployment_scripts/
describing how and when to use each script (example commands, etc.) - Does this build the dev container image? Ideally this should build the base image (same tag as dev), it is 1 GB smaller
e29e7d8
to
ab93438
Compare
ab93438
to
7ddd425
Compare
@patrick-5546 all comments have been addressed. |
…mate-building-and-running-base-image-on-rpi-with-docker-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple changes to fit the deployment workflow I documented in the README, if it looks good to you feel free to merge
Description
Verification