Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work In Progress: Update dependencies and Dart SDK in workflows #730

Merged
merged 6 commits into from
Jan 19, 2022

Conversation

UnHumbleBen
Copy link
Collaborator

Testing Dart CI workflow by triggering it through this pull request

@UnHumbleBen
Copy link
Collaborator Author

UnHumbleBen commented Jan 18, 2022

Description

Updated dependencies in response to OverReact upgrade to version 4.2.6.

scadnano workflows will now use Dart SDK 2.13 instead of 2.9 because Dart SDK 2.9 is no longer supported by OverReact. Dart SDK 2.13 is the newest SDK supported by OverReact because newer versions rely on analyzer 1.x, which OverReact does not support as noted in the OverReact workflow file.

react_components_test_template.html has been updated in response to upgrading test_html_builder from version 1 to version 2.

Lastly, to ensure that our developers are working on the app with the exact same versions, I committed the pubspec.lock file. This is recommended for application packages, as noted in the Dart documentation.

Related Issue

#706

How Has This Been Tested?

  • Ran unit tests locally
  • Run Dart CI workflow
  • Run github-pages-dev workflow on fork
  • Run github-pages workflow on fork
  • Have @dave-doty test out the changes by pulling this branch and see if he can still run webdev serve and unit tests.

@dave-doty
Copy link
Member

Do you think we should change this line:

environment:
  sdk: '>=2.9.0 <3.0.0'

to

environment:
  sdk: '>=2.11.0 <3.0.0'

Since OverReact is going to require >=2.11 anyway?

@dave-doty
Copy link
Member

dave-doty commented Jan 18, 2022

I am able to rub locally after running

pub get

then

webdev serve

Unit tests (running ./tests.sh) also pass.

It's annoying that we still get the analyzer warning:

image

But it appears that OverReact is still requiring the old version of analyzer:

https://github.com/Workiva/over_react/blob/7ee4fc2c07761a02d0f0a9577c4296b7a10e41a9/pubspec.yaml#L8-L13

@UnHumbleBen UnHumbleBen marked this pull request as ready for review January 19, 2022 04:10
@UnHumbleBen
Copy link
Collaborator Author

@dave-doty Updated SDK requirement in pubspec.yaml and fixed and tested the Github workflows, as indicated above. Ready to merge as soon as changes are approved.

@UnHumbleBen UnHumbleBen merged commit 902bea2 into dev Jan 19, 2022
@UnHumbleBen UnHumbleBen deleted the update-dependencies-#706 branch January 19, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants