Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_drift argument does not appear to work #89

Closed
telegraphic opened this issue Aug 4, 2020 · 6 comments
Closed

min_drift argument does not appear to work #89

telegraphic opened this issue Aug 4, 2020 · 6 comments

Comments

@telegraphic
Copy link
Collaborator

As noted by @ssmith00, Output .dat files clearly contain values below the minimum drift rate. Needs a fix and a unit test.

@telegraphic telegraphic added the bug label Aug 4, 2020
@texadactyl
Copy link
Contributor

texadactyl commented Dec 26, 2020

@telegraphic @ssmith00 @luigifcruz

  • By "values below the minimum drift rate", do you mean in absolute value or signed value? Should the supplied parameter in FindDoppler __init__() be an absolute value or a signed value? Yes, I am probably showing a lack of understanding about the subject of "drift" and "drift rate".

  • Same questions for the max_drift parameter?

@texadactyl
Copy link
Contributor

texadactyl commented Dec 27, 2020

Overdue: adding a --min-drift parameter to seti_event.py and allowing a default max_drift value in FindDoppler init().

@texadactyl texadactyl reopened this Dec 27, 2020
@texadactyl texadactyl self-assigned this Jan 30, 2021
texadactyl added a commit that referenced this issue Jan 30, 2021
Version 2.0.8 - Fix issues #89, #178, and #179
@texadactyl
Copy link
Contributor

texadactyl commented Jan 30, 2021

@telegraphic @ssmith00
Closing this issue because I was able to reproduce the issue before PR #180 in a variety of files but afterwards, I observe the desired behviour. Would it be possible for either of you to try again the case which provided the error symptoms?

UPDATE on 2021-02-23: I unfortunately "verified" with a couple of setigen-generated files. This was an error and this issue has been re-opened.

@texadactyl
Copy link
Contributor

@telegraphic @ssmith00
I forgot to mention that turboSETI now accepts a minimum drift rate parameter (issue #178).

@texadactyl
Copy link
Contributor

Verified to still be broken somewhere in search_coarse_channel().

@texadactyl texadactyl reopened this Feb 23, 2021
@texadactyl texadactyl removed their assignment Feb 23, 2021
texadactyl added a commit that referenced this issue Feb 25, 2021
@texadactyl texadactyl pinned this issue Feb 25, 2021
@texadactyl texadactyl self-assigned this Feb 26, 2021
@texadactyl
Copy link
Contributor

Reviewers: A proposed fix is in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants