Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add frequency channel masking capability. Issue #125. #133

Merged
merged 7 commits into from
Dec 31, 2020

Conversation

luigifcruz
Copy link
Contributor

@luigifcruz luigifcruz commented Dec 19, 2020

This pull-request addresses Issue #125 by adding frequency masking to the input file. A YAML file containing a list of blocked frequency ranges (blacklist) is used to configure the masking behavior. The user can enable this feature in runtime using the command-line flag -m for the default mask file mask.yml or explicitly specifying the path using the --mask PATH argument. The proposed syntax of the YAML file is described below. Alll frequencies in MHz.

Case 1

Block frequencies from 2400 MHz to 3600 MHz and from 4800 MHz to 9600 MHz.

blacklist:
  - range:
    - start: 2400
    - stop: 3600
  - range:
    - start: 4800
    - stop: 9600

Case 2

Block all frequencies.

blacklist:
  - range:
    - start: 0
    - stop: 1.0e9

Case 3

Block all frequencies up to 2400 MHz.

blacklist:
  - range:
    - start: 0
    - stop: 2400

@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #133 (5117720) into master (a80db51) will decrease coverage by 1.79%.
The diff coverage is 17.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   83.23%   81.44%   -1.80%     
==========================================
  Files          23       23              
  Lines        1593     1638      +45     
==========================================
+ Hits         1326     1334       +8     
- Misses        267      304      +37     
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
turbo_seti/find_doppler/find_doppler.py 95.19% <ø> (ø)
turbo_seti/find_doppler/data_handler.py 72.46% <15.90%> (-15.27%) ⬇️
turbo_seti/find_doppler/seti_event.py 82.75% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80db51...fb1077e. Read the comment docs.

@luigifcruz
Copy link
Contributor Author

Does the proposed syntax meet your needs, @wfarah? How can we improve it?

@texadactyl
Copy link
Contributor

Issue 135 is highest priority. The future resolution to the 2.0.2 base will impact this PR.

@texadactyl texadactyl closed this Dec 22, 2020
@luigifcruz
Copy link
Contributor Author

I think we can open this PR again since #135 is resolved.

@texadactyl texadactyl reopened this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants