Wavelet Multiplication + Nonstandard transforms #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes in functionalities in current patch update. Only fixes and additions are made to follow JOSS guidelines.
letter size paper
Fixes to JOSS code snippets.
Organize source code of the same purpose into a subdirectory. Eg: ``` src/ACWT.jl src/ACWT.jl src/acwt_all.jl -> src/acwt/acwt_all.jl src/acwt_one_level.jl src/acwt/acwt_one_level.jl src/acwt_utils.jl src/acwt/acwt_utils.jl ```
- Update function documentations - Add `ns_idwt`, `nonstd_wavemult` to be exported from module.
Updates: - Standard form wavelet multiplication. - Documentation for `WaveMult` module. TODO: - Add examples in `WaveMult` documentations.
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 98.22% 98.29% +0.06%
==========================================
Files 23 27 +4
Lines 3103 3218 +115
==========================================
+ Hits 3048 3163 +115
Misses 55 55
Continue to review full report at Codecov.
|
- Added parentheses to condition evaluation in `stretchmatrix` function. This improves the condition evaluation process that was previously buggy and produces the wrong logical expressions. - Added a line in `mat2sparseform_nonstd` function. Previous implementation did not produce the right answer.
In both `mat2sparse_nonstd` and `mat2sparse_std` functions, the line ``` maxcolnorm = (maximum ∘ mapslices)(norm, Mw, dims = 1) ``` is changed to ``` maxcolnorm = mapslices(norm, Mw, dims = 1) |> maximum ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
src/mod/folderWaveMultmoduleWaveMultmodule