Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altering Set up site visit to safely manage data. #282

Open
Elijahwalkerwest opened this issue Apr 6, 2018 · 3 comments
Open

Altering Set up site visit to safely manage data. #282

Elijahwalkerwest opened this issue Apr 6, 2018 · 3 comments

Comments

@Elijahwalkerwest
Copy link

Currently when you update or create a site visit, it deletes the data before re-creating it from the request. This is really bad data management.

This causes data to be deleted if for some reason it can't create the new object. Big problem.

So I am updating this view to manage data more responsibly.

@AmberSJones
Copy link

I'm not sure how to test this. @Elijahwalkerwest , you can give me some steps to walk through, or if you are convinced that it is addressed (by doing some testing of your own), you can close it.

@AmberSJones
Copy link

@Elijahwalkerwest ditto the previous comment.

@Elijahwalkerwest
Copy link
Author

Testing this involves intentionally breaking some code. I.E. making sure that if different parts of editing/creating site visits break, it doesn't break data. I'm testing this myself, I'll update and close when I feel more confident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants