Always ignore template at top level pre-commit #320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lint at the top level, and at the template level. It doesn't really make sense to template both, and some of the hooks get confused with the
cookiecutter
templating. Previously, we were ignoring some, but actually makes sense to ignore it all.The downside is that locally it will be annoying to lint at the package level. But that is fine because CI with lint at the template level. Sometimes you may need to create a dummy project to fix the issue.