Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native TOML support for tox #460

Merged
merged 21 commits into from
Oct 14, 2024
Merged

Native TOML support for tox #460

merged 21 commits into from
Oct 14, 2024

Conversation

paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Oct 11, 2024 •
edited
Loading

Fixes #455. In order to do this, have also switched from tox-gh-actions to tox-gh. Has been tested in astro-informatics/sleplet#420, astro-informatics/sleplet#421.

  • Will need to check if templating works correctly

@paddyroddy paddyroddy added the enhancement New feature or request label Oct 11, 2024
@paddyroddy paddyroddy self-assigned this Oct 11, 2024
@paddyroddy paddyroddy marked this pull request as ready for review October 11, 2024 10:21
@paddyroddy paddyroddy marked this pull request as draft October 11, 2024 10:21
@dstansby
Copy link
Member

I would just filter .pyc files out of the comparison (like the .git folder is) to make it a bit easier

@paddyroddy
Copy link
Member Author

I would just filter .pyc files out of the comparison (like the .git folder is) to make it a bit easier

Ah, thanks, that bit was annoying me. Guessing it is a difference between tox-gh and tox-gh-actions.

@paddyroddy
Copy link
Member Author

Thanks @dstansby!

@paddyroddy paddyroddy mentioned this pull request Oct 11, 2024
Closed
@paddyroddy paddyroddy marked this pull request as ready for review October 11, 2024 14:33
samcunliffe
samcunliffe approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. We should probably add it to our recommendations page? Because toml-er is better.

@paddyroddy paddyroddy mentioned this pull request Oct 14, 2024
Open
@paddyroddy
Copy link
Member Author

This looks great. We should probably add it to our recommendations page? Because toml-er is better.

👍 have raised #461

@paddyroddy paddyroddy merged commit a867d7b into main Oct 14, 2024
12 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-455 branch October 14, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcunliffe samcunliffe samcunliffe approved these changes

@matt-graham matt-graham Awaiting requested review from matt-graham

@dstansby dstansby Awaiting requested review from dstansby

Assignees

@paddyroddy paddyroddy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt native TOML tox support
3 participants
@paddyroddy @dstansby @samcunliffe