last_connection and creation date feature #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiraux
reviewed
Nov 14, 2018
ictv/models/user.py
Outdated
| @@ -83,6 +85,13 @@ def get_subscriptions_of_owned_screens(self): | |||
| if UserPermissions.administrator in self.highest_permission_level: | |||
| return Subscription.select() | |||
| return self.screens.throughTo.subscriptions | |||
|
|
|||
| def reconnect_since_creation(self): | |||
| if self.creation_date is None or self.last_connection is None: | |||
There was a problem hiding this comment.
So any existing user will never be considered to have been connected ? This is a tricky case that must be handle, my suggestion would be to set the creation_date of all existing users to the database update date.
mpiraux
reviewed
Nov 15, 2018
mpiraux
reviewed
Nov 15, 2018
mpiraux
reviewed
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this to detect inactive users (well to read that they are inactive).
If it's useless, you can delete this branch.