Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I created a test file #11

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

I created a test file #11

wants to merge 7 commits into from

Conversation

CoreyFulop
Copy link

I think pytest is pretty cool! I had to stare at the times.py code for about 10 minutes before I understood what was happening...

This test file has just the one test, but there are so many other "fixtures" - is this the correct term? - we could examine: eg. no overlap in time, does this return an empty list?

Answers UCL-MPHY0021-21-22/RSE-Classwork#16

@alessandrofelder
Copy link
Contributor

alessandrofelder commented Nov 4, 2021

This test file has just the one test, but there are so many other "fixtures" - is this the correct term?

Fixtures are useful functions and data that help setting up (and tearing down) the tests, but not the tests themselves (or the ideas behind them). You can read more about what fixtures are and how to use them in the pytest docs!

Copy link
Contributor

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of the tests are failing on the CI - I think you may not have fixed the bug in times.py yet?
Otherwise, looks largely good to me 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants