Test exercise time #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| with pytest.raises(ValueError): | ||
| test1 = time_range("2010-01-12 12:00:00", "2010-01-12 10:00:00") | ||
| test2 = time_range("2010-01-12 11:00:00", "2010-01-12 10:30:00") |
There was a problem hiding this comment.
If the code in line 28 raises a ValueError (as it should!) this line will never be executed!
There was a problem hiding this comment.
You should also check that the error message is what you expect!
| result = compute_overlap_time(large, short) | ||
| print(result) | ||
| expected = [('2010-01-12 10:30:00', '2010-01-12 10:34:20'), ('2010-01-12 10:35:20', '2010-01-12 10:36:30'), ('2010-01-12 10:38:30', '2010-01-12 10:39:40'), ('2010-01-12 10:40:40', '2010-01-12 10:45:00')] | ||
| print(expected) |
There was a problem hiding this comment.
Nice!
This is a good test - but you can see that it gets quite hard to read very quickly. You might want to move some of the data into a fixture - which is in fact homework: UCL-MPHY0021-21-22/RSE-Classwork#22 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a test file and function to test the overlap function.
Created function for both overlapping and non-overlapping
Answers UCL-MPHY0021-21-22/RSE-Classwork#16