Created test file. #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shout-out to @shashvatshukla for his many insights |
| short = time_range("2011-01-12 10:30:00", "2011-01-12 10:45:00", 2, 60) | ||
| print(compute_overlap_time(large, short)) | ||
| result = compute_overlap_time(large, short) | ||
| expected = [] |
There was a problem hiding this comment.
Why do you expect the overlap between large and short to be [] here?
| assert result == expected | ||
|
|
||
|
|
||
| test_given_input() |
There was a problem hiding this comment.
You don't need this here - pytest will automatically find and run functions whose name starts with test!
| @@ -18,9 +22,12 @@ def compute_overlap_time(range1, range2): | |||
| low = max(start1, start2) | |||
| high = min(end1, end2) | |||
| overlap_time.append((low, high)) | |||
There was a problem hiding this comment.
Should we add an overlap to the overlap_time list if low > high?
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
This file (and the two .pyc files below) should not be tracked by git! They are specific to your local set-up (which is probably different to everyone elses!)...See gitignore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS code supports testing with pytest- makes my life a lot better