Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answers UCL-MPHY0021-21-22/RSE-Classwork#16 #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ziyang-Yan
Copy link

Something goes wrong when I try to use
from .times import *
I need to switch to
from times import *

Copy link
Contributor

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Made a tiny style-related comment.

Comment on lines +1 to +2
from times import time_range
from times import compute_overlap_time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do this in one line (but what you did is correct!)

Suggested change
from times import time_range
from times import compute_overlap_time
from times import compute_overlap_time, time_range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants