Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Xenofon-Chiotopoulos
Copy link

Classwork. managed to complete the first function, but not the rest.

Copy link
Contributor

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional test and bugfix look good.
Made a comment that hopefully helps along with the CI side 🙂

@@ -0,0 +1 @@

Copy link
Contributor

@alessandrofelder alessandrofelder Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows/ should be a folder (which in turn contains one or more YAML files), but I think you've made it a file. It might be worth looking the GitHub Actions quickstart guide in your own time (I'm aware there wasn't as much time in class!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants