Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arosi time fork #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Arosi time fork #23

wants to merge 2 commits into from

Conversation

AbsArosi
Copy link

@AbsArosi AbsArosi commented Nov 4, 2021

Struggled to understand the discussion during the zoom call regarding the error in login for compute_overlap_time(). Implemented something else instead.

alessandrofelder
alessandrofelder reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's a completely valid fix to the bug, as far as I can tell - well done!
A slightly shorter, logically equivalent alternative might be

if low < high:
    overlap_time.append((low, high))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbsArosi @alessandrofelder