Add test file for compute overlap time #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add coverage to test
Write coverage as separate test
.github/workflows/python-tests.yml
Outdated
Comment on lines
24
to
29
| - name: Test with pytest | ||
| run: | | ||
| pytest | ||
| - name: Test coverage | ||
| run: | | ||
| pytest --cov=. |
There was a problem hiding this comment.
You might want to combine these two steps into one, so you don't run the tests twice!
| @@ -0,0 +1,34 @@ | |||
| generic: | |||
| time_range_1: | |||
| - !!python/tuple ['2010-01-12 10:00:00', '2010-01-12 12:00:00'] | |||
There was a problem hiding this comment.
Nice, I didn't know about Python-specific tags in PyYAML - as you probably realise, this will prevent you from re-using the data in a different programming language... but probably that's also not a good idea in the first place 🤔
test_times.py
Outdated
Comment on lines
9
to
13
| @pytest.mark.parametrize("time_range_1,time_range_2,expected", [(fixture["generic"]["time_range_1"],fixture["generic"]["time_range_2"], fixture["generic"]["expected"]),\ | ||
| (fixture["no_overlap"]["time_range_1"], fixture["no_overlap"]["time_range_2"], fixture["no_overlap"]["expected"]),(fixture["several_intervals"]["time_range_1"],\ | ||
| fixture["several_intervals"]["time_range_2"], fixture["several_intervals"]["expected"]), (fixture["same_time"]["time_range_1"], fixture["same_time"]\ | ||
| ["time_range_2"], fixture["same_time"]["expected"])]) | ||
|
|
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize("time_range_1,time_range_2,expected", [(fixture["generic"]["time_range_1"],fixture["generic"]["time_range_2"], fixture["generic"]["expected"]),\ | |
| (fixture["no_overlap"]["time_range_1"], fixture["no_overlap"]["time_range_2"], fixture["no_overlap"]["expected"]),(fixture["several_intervals"]["time_range_1"],\ | |
| fixture["several_intervals"]["time_range_2"], fixture["several_intervals"]["expected"]), (fixture["same_time"]["time_range_1"], fixture["same_time"]\ | |
| ["time_range_2"], fixture["same_time"]["expected"])]) | |
| @pytest.mark.parametrize("time_range_1,time_range_2,expected", | |
| [ | |
| (fixture["generic"]["time_range_1"], fixture["generic"]["time_range_2"], fixture["generic"]["expected"]),\ | |
| (fixture["no_overlap"]["time_range_1"], fixture["no_overlap"]["time_range_2"], fixture["no_overlap"]["expected"]),\ | |
| (fixture["several_intervals"]["time_range_1"], fixture["several_intervals"]["time_range_2"], fixture["several_intervals"]["expected"]),\ | |
| (fixture["same_time"]["time_range_1"], fixture["same_time"]["time_range_2"], fixture["same_time"]["expected"]) | |
| ]) |
or something like this, possibly better done with an automatic formatter, would maybe make this more readable 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers UCL-MPHY0021-21-22/RSE-Classwork#16
I hadn't used pytest before so was interesting to see it work, and writing test functions using "assert".