Minor clean-up of ProjDataInfoBlocksOnCylindricalNoArcCorr #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KrisThielemans
commented
Dec 20, 2024
KrisThielemans
commented
- remove unused file
- fix some includes
- make 2 deprecated members private (on the long path to resolving remove obsolete functions in ProjDataInfoCylindrical and ProjDataInfoCylindricalNoArcCorr #105). Note that this in principle breaks backwards compatibility, but they are unused, and I'd prefer to merge this in 6.3 to make some progress...
- ProjDataInfoBlocksOnCylindricalNoArcCorr defines 2 deprecated (see UCL#105) functions that are only used in tests, so I made them private. - removed unused file WARNING: this in principle breaks backwards compatibility.
KrisThielemans
force-pushed
the
BlocksMinorCleanup
branch
from
15faeed to
23e5663
Compare
ProjDataInfoBlocksOnCylindrical is identical to ProjDataInfoGeneric and should not be used any more. I removed some dynamic checks on ProjDataInfoBlocksOnCylindrical and use the fall-back to generic. Note however that this code was never used, as currently the ProjDataInfoCylindrical case will always be used.
KrisThielemans
force-pushed
the
BlocksMinorCleanup
branch
from
23e5663 to
041f6de
Compare
|
I removed some dynamic checks on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.