Release4 to master 16 sep2020 #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed some changes in ProjDataGEHDF5 to construct the projdata_info itself
- fixed some types to be consistent - commented out unused m_NX etc
some code wasn't used, and generated warnings with clang.
…ic for checking Signa
Co-authored-by: Kris Thielemans <KrisThielemans@users.noreply.github.com>
- Scanner.cxx name has to match with what GE uses - we were initialising a local scanner_sptr as opposed to the member variable
…canner Otherwise we get conflicts on the scanner
write some warnings and reading effective-ring-radius
related UCL#555, fixes evguenis bug report.
also correct number of rings for DMI3
Seems that RDF9 may have it in sometimes....
Forgotten to commit this update in UCL#634
Some listmode files can contain events of size 6, 8 or 16. We assumed it was always 6. Fixes UCL#679
- low/high energy window info were swapped - exam info wasn't set for listmode data
first "skip" has to be in seconds as well
- read patient_position - read bed positions for proj-data created new functions in GEHDF5Wrapper to do this: - initialise_proj_data_info, and get_proj_data_info_sptr (allowing cleaning up some code elsewhere) - 2 utilities read_dataset_int32
- changed some more references from the Signa to RDF9 - added Ander in a few places - removed some obsolete/commented out code
Multiplicative factor taking duration into account was wrong (for listmode data we were using times duration as opposed to divide by it, for sinogram data it was 1). In addition, we also take decay into account now (assuming F-18).
construct_randoms_from_GEsingles needs to be called with the actual unlisted projdata. Otherwise, timing information would be incorrect.
do avoid some duplication, I've moved the norm stuff to a separate script
InvertAxis cleanup. Fixes UCL#459
Also moved printing of exam_info to ExamInfo::parameter_info() to reduce duplication
extend GE RDF9 raw data support to other GE PET/CT scanners that use RDF9
added list_lm_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.