Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TB culture HSI #1453

Merged
merged 23 commits into from
Dec 17, 2024
Merged

add TB culture HSI #1453

merged 23 commits into from
Dec 17, 2024

Conversation

tdm32
Copy link
Collaborator

@tdm32 tdm32 commented Aug 5, 2024

This branch has the HTM scale-up scenarios plus the new culture diagnostic test for tb which is used for people with a false test (xpert, sputum, xray or clinical) but all the symptoms indicative of tb. It is only called if program scale-up is 'target' or 'max'

tbhallett and others added 5 commits July 29, 2024 15:36
@tdm32 tdm32 requested a review from tbhallett August 5, 2024 15:45
@tbhallett
Copy link
Collaborator

Thanks Tara -- running now.

For the review, maybe we should allow this to happen only under 'max', since we think it's quite hypothetical?

@tdm32
Copy link
Collaborator Author

tdm32 commented Aug 6, 2024

Thanks Tara -- running now.

For the review, maybe we should allow this to happen only under 'max', since we think it's quite hypothetical?

Sure. I think it will depend on what we want to present, are you thinking that we only present the max scenario? The targeted scenario will likely show a very muted effect.

@tbhallett
Copy link
Collaborator

tbhallett commented Sep 4, 2024

Thanks @tdm32 --- do we want to roll-back the analysis scripts on here, so that it's just the changes to the TB module....? Or, are you using this for your production runs for your current GF and FCDO analyses?

@tdm32
Copy link
Collaborator Author

tdm32 commented Dec 10, 2024

Thanks @tdm32 --- do we want to roll-back the analysis scripts on here, so that it's just the changes to the TB module....? Or, are you using this for your production runs for your current GF and FCDO analyses?

@tbhallett I've rolled back those files which do exist on master. Additional analysis scripts on this branch - which are not present in master - don't need to be pushed. Should we delete them or can we just merge those relevant files?

Required for merge to master:
resources/healthsystem/priority_policies/ResourceFile_PriorityRanking_ALLPOLICIES.xlsx
src/tlo/methods/tb.py

@tbhallett
Copy link
Collaborator

Are we keeping this or closing it off? @tdm32

@tbhallett
Copy link
Collaborator

tbhallett commented Dec 13, 2024

@tdm32 on this one:

  • there are lots of script file from the FCDO/GF analysis bundled in here, that I presume we don't want to come in on this PR. I believe the only changes needed are in tb.py. If so, please roll back the others\

  • I see that with the last merge in of master, there were failing tests -- so after that fix, we'll need to wait for the test to pass.

Comment on lines 2144 to 2147
if self.suppress_footprint:
return self.make_appt_footprint({})
else:
return ACTUAL_APPT_FOOTPRINT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where the option to suppress the footprint is exercised? Just checking if it should be, given that you've put this logic in?

Also - no need for the else clause: no return, implies that ( return ACTUAL_APPT_FOOTPRINT) anyway and Is quicker.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this now

@tbhallett
Copy link
Collaborator

@tdm32 --- I've removed the files that I think didn't want to be on this PR. The .xlsx for Priority Polices look the same to me? Are you sure we need to update?

@tdm32
Copy link
Collaborator Author

tdm32 commented Dec 17, 2024

@tdm32 --- I've removed the files that I think didn't want to be on this PR. The .xlsx for Priority Polices look the same to me? Are you sure we need to update?

@tbhallett there should be the additional HSI for TB culture in the priority policies sheets

@tbhallett tbhallett merged commit a4fc9b2 into master Dec 17, 2024
62 checks passed
@tbhallett tbhallett deleted the hallett/test_run_htm_scale_up branch December 17, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants